From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25172: 26.0.50; Concurrency feature, sit-for doesn't work (crashing and unexpected behaviour) Date: Wed, 14 Dec 2016 18:03:11 +0200 Message-ID: <83pokua474.fsf@gnu.org> References: <838trme4jr.fsf@gnu.org> <838trlcals.fsf@gnu.org> <83vauobiou.fsf@gnu.org> <83fulrbxsd.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1481731546 3856 195.159.176.226 (14 Dec 2016 16:05:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Dec 2016 16:05:46 +0000 (UTC) Cc: 25172@debbugs.gnu.org, clement.pit@gmail.com To: Elias =?UTF-8?Q?M=C3=A5rtenson?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 14 17:05:43 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHC3f-0007fj-Vb for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Dec 2016 17:05:32 +0100 Original-Received: from localhost ([::1]:48581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHC3k-0008TK-8B for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Dec 2016 11:05:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHC3K-0007Tp-F0 for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2016 11:05:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHC3C-0008H5-M4 for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2016 11:05:10 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cHC3C-0008Gx-Io for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2016 11:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cHC3C-0005hg-8D for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2016 11:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Dec 2016 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25172 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25172-submit@debbugs.gnu.org id=B25172.148173144821854 (code B ref 25172); Wed, 14 Dec 2016 16:05:02 +0000 Original-Received: (at 25172) by debbugs.gnu.org; 14 Dec 2016 16:04:08 +0000 Original-Received: from localhost ([127.0.0.1]:41979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHC2J-0005gO-L1 for submit@debbugs.gnu.org; Wed, 14 Dec 2016 11:04:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHC2I-0005fz-R7 for 25172@debbugs.gnu.org; Wed, 14 Dec 2016 11:04:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHC2A-0007qt-MK for 25172@debbugs.gnu.org; Wed, 14 Dec 2016 11:04:01 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHC2A-0007qp-JK; Wed, 14 Dec 2016 11:03:58 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3767 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cHC2A-0004Dp-3K; Wed, 14 Dec 2016 11:03:58 -0500 In-reply-to: (message from Elias =?UTF-8?Q?M=C3=A5rtenson?= on Wed, 14 Dec 2016 10:58:36 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127030 Archived-At: > From: Elias Mårtenson > Date: Wed, 14 Dec 2016 10:58:36 +0800 > Cc: Clément Pit--Claudel , > 25172@debbugs.gnu.org > > Can you try removing the calls to block_input/unblock_input from > xgselect.c, and see if these crashes then stop? > > I have tried this now, and it's much more stable now. It doesn't immediately crash, and sometimes it doesn't > crash at all. > > When it crashes, it does so after several seconds, and I have captured two of these crashes. Thanks. Does the patch below help in any way with these crashes? If not, it sounds like I'm out of my depth here. The crashes you show are deep in the bowels of Glib called by GTK; reading the (annoyingly minimal) documentation of those APIs, I sense the danger of some basic issue with calling these APIs from several threads. If what the GTK documentation tells everything there is to it, then the patch below should fix these problems. But if not, then I guess we will need help from a GTK expert. diff --git a/src/xgselect.c b/src/xgselect.c index 2f23764..a9461a5 100644 --- a/src/xgselect.c +++ b/src/xgselect.c @@ -150,7 +150,7 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds, fd_set *efds, #else need_to_dispatch = true; #endif - if (need_to_dispatch) + if (need_to_dispatch && context_acquired) { int pselect_errno = errno; /* Prevent g_main_dispatch recursion, that would occur without