From: Eli Zaretskii <eliz@gnu.org>
To: Steve Purcell <steve@sanityinc.com>
Cc: 26490@debbugs.gnu.org
Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive
Date: Fri, 14 Apr 2017 10:31:05 +0300 [thread overview]
Message-ID: <83pogfh2di.fsf@gnu.org> (raw)
In-Reply-To: <m260i7q0sg.fsf@sanityinc.com> (message from Steve Purcell on Fri, 14 Apr 2017 12:44:24 +1200)
> From: Steve Purcell <steve@sanityinc.com>
> Date: Fri, 14 Apr 2017 12:44:24 +1200
>
> `package-buffer-info' looks for an "filename.el ends here" comment line,
> where "filename.el" matches that provided on the first line of the
> file. However, it does not set `case-fold-search' to nil explicitly, and
> so will happily allow "FiLeNaMe.EL" in the trailing line.
>
> I rely on this function in package-lint to detect certain issues with
> packaging, and noticed this failure there. I can work around it by
> unsetting `case-fold-search', but this seems the wrong fix.
Why do you think it would be wrong for you in your special use case to
bind case-fold-search to nil? I think it's exactly the right
solution.
> A simple patch is attached.
What about Emacs running on case-insensitive filesystems? What will
your patch do in that case?
Thanks.
next prev parent reply other threads:[~2017-04-14 7:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 0:44 bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Steve Purcell
2017-04-14 7:31 ` Eli Zaretskii [this message]
2017-04-14 9:12 ` Steve Purcell
2017-04-14 20:29 ` Glenn Morris
2017-04-14 23:02 ` Steve Purcell
2019-08-24 5:57 ` Stefan Kangas
2019-08-24 6:35 ` Steve Purcell
2019-09-28 10:55 ` Stefan Kangas
2019-10-01 23:54 ` Basil L. Contovounesios
2019-10-04 12:48 ` Stefan Kangas
2019-10-20 14:16 ` Stefan Kangas
2019-10-21 16:05 ` Stefan Monnier
2019-11-02 0:31 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pogfh2di.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26490@debbugs.gnu.org \
--cc=steve@sanityinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).