From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without confirmation Date: Mon, 14 Aug 2017 18:34:30 +0300 Message-ID: <83pobygo3d.fsf@gnu.org> References: <61980dde-3d68-7200-e7f4-98f62e410060@cs.ucla.edu> <0e80a1cf-8217-9e9a-a00f-9fdbd6575fc4@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502724960 5011 195.159.176.226 (14 Aug 2017 15:36:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Aug 2017 15:36:00 +0000 (UTC) Cc: p.stephani2@gmail.com, 27986@debbugs.gnu.org To: Paul Eggert , Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 14 17:35:55 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhHP8-0000ak-LE for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Aug 2017 17:35:46 +0200 Original-Received: from localhost ([::1]:55985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhHPF-0005eE-0T for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Aug 2017 11:35:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhHOT-00055z-Il for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 11:35:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhHOQ-0007yP-Ft for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 11:35:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55096) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhHOQ-0007yC-CH for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 11:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dhHOQ-0004do-3o for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Aug 2017 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27986-submit@debbugs.gnu.org id=B27986.150272488717831 (code B ref 27986); Mon, 14 Aug 2017 15:35:02 +0000 Original-Received: (at 27986) by debbugs.gnu.org; 14 Aug 2017 15:34:47 +0000 Original-Received: from localhost ([127.0.0.1]:35544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhHOA-0004dX-Ll for submit@debbugs.gnu.org; Mon, 14 Aug 2017 11:34:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhHO8-0004dR-LQ for 27986@debbugs.gnu.org; Mon, 14 Aug 2017 11:34:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhHO0-0007ns-97 for 27986@debbugs.gnu.org; Mon, 14 Aug 2017 11:34:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhHO0-0007nn-6g; Mon, 14 Aug 2017 11:34:36 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4335 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dhHNz-0004PA-Kv; Mon, 14 Aug 2017 11:34:36 -0400 In-reply-to: <0e80a1cf-8217-9e9a-a00f-9fdbd6575fc4@cs.ucla.edu> (message from Paul Eggert on Sun, 13 Aug 2017 16:48:59 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135744 Archived-At: > From: Paul Eggert > Cc: Eli Zaretskii , 27986@debbugs.gnu.org > Date: Sun, 13 Aug 2017 16:48:59 -0700 > > Getting back to Philipp's original bug report, Apple documentation says macOS > has a facility like the Linux renameat2 system call (i.e., it's like 'renameat' > except it can be told to fail if the destination already exists). Attached is a > proposed patch to use this facility, which means that the case-insensitivity > test would no longer need to be done in macOS. If there's some way to implement > renameat_noreplace on MS-Windows we could get rid of the case-insensitivity test > there too. There's nothing easier than implementing renameat_noreplace on MS-Windows, since the underlying system call does that by default, and it's emulating the Posix behavior that requires complications. In fact, we already have this implementation: see sys_rename_replace (in w32.c) which needs to be called with its last argument FALSE (modulo the "at" part, which is easily handled). (Ken, what about Cygwin?) So I think we may be able to remove the case-sensitivity check right now. And in any case, that check should be in barf_or_query_if_file_exists anyway, because renameat_noreplace on case-insensitive filesystems already supports renaming to a different letter-case. The reason we had this check before is because we didn't employ renameat_noreplace, but called 'rename' right away, and that needed a question before overwriting the target. But now renameat_noreplace will silently succeed to rename when the user wants to only change the letter-case, so no such check is needed.