From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Mon, 11 Sep 2017 19:04:42 +0300 Message-ID: <83poaxrzl1.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505145995 7535 195.159.176.226 (11 Sep 2017 16:06:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Sep 2017 16:06:35 +0000 (UTC) Cc: larsi@gnus.org, 28402@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 11 18:06:28 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drRDu-0000q5-2T for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 18:06:10 +0200 Original-Received: from localhost ([::1]:58757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drRE1-0000M0-Bj for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 12:06:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drRDr-0000KF-TZ for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:06:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drRDm-0004gv-Aw for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:06:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53329) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drRDm-0004go-74 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drRDm-0007Ev-0M for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2017 16:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.150514595727818 (code B ref 28402); Mon, 11 Sep 2017 16:06:01 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 11 Sep 2017 16:05:57 +0000 Original-Received: from localhost ([127.0.0.1]:33777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drRDd-0007EZ-CH for submit@debbugs.gnu.org; Mon, 11 Sep 2017 12:05:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drRDY-0007EJ-FT for 28402@debbugs.gnu.org; Mon, 11 Sep 2017 12:05:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drRDO-0004S4-Vn for 28402@debbugs.gnu.org; Mon, 11 Sep 2017 12:05:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drRCg-00044C-0K; Mon, 11 Sep 2017 12:04:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4418 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1drRCe-00052i-SJ; Mon, 11 Sep 2017 12:04:53 -0400 In-reply-to: (message from Vasilij Schneidermann on Sat, 9 Sep 2017 21:39:39 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136790 Archived-At: > From: Vasilij Schneidermann > Date: Sat, 9 Sep 2017 21:39:39 +0200 > Cc: larsi@gnus.org > > I'm using shr.el for a package and override `shr-tag-img` by let-binding > `shr-external-rendering-functions` to an alist containing an alternative > rendering function that deals better with local images. Despite this > `shr-tag-img` is still directly called when rendering tables with images > inside them. The same problem applies to other directly called > rendering functions, as opposed to indirectly called ones as seen in > `shr-descend`, the function honoring `shr-external-rendering-functions`. >From a cursory look into shr.el, it looks like shr-external-rendering-functions were introduced to support some specific eww.el needs, not as a general lever for tweaking shr.el from outside it. That's why only a handful of functions honor that variable. Would you like to submit a patch that would make all shr-tag-* functions consult that variable first?