From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29422: 27.0.50; Symbol enable-multibyte-characters may not be buffer-local Date: Sun, 26 Nov 2017 17:31:36 +0200 Message-ID: <83po856opz.fsf@gnu.org> References: <87vai0w1mt.fsf@web.de> <87y3mvxibw.fsf@web.de> <83h8ti94le.fsf@gnu.org> <834lpi8eek.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1511710334 29118 195.159.176.226 (26 Nov 2017 15:32:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 26 Nov 2017 15:32:14 +0000 (UTC) Cc: michael_heerdegen@web.de, 29422@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 26 16:32:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIyuX-0006ih-8M for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Nov 2017 16:32:01 +0100 Original-Received: from localhost ([::1]:57038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIyue-0003bl-GF for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Nov 2017 10:32:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIyuY-0003be-OQ for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 10:32:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIyuY-0005c9-1U for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 10:32:02 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eIyuX-0005bn-TG for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 10:32:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eIyuX-00072p-Jq for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 10:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Nov 2017 15:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29422-submit@debbugs.gnu.org id=B29422.151171032027072 (code B ref 29422); Sun, 26 Nov 2017 15:32:01 +0000 Original-Received: (at 29422) by debbugs.gnu.org; 26 Nov 2017 15:32:00 +0000 Original-Received: from localhost ([127.0.0.1]:59461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIyuW-00072a-IC for submit@debbugs.gnu.org; Sun, 26 Nov 2017 10:32:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIyuU-00072M-Nh for 29422@debbugs.gnu.org; Sun, 26 Nov 2017 10:31:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIyuM-0005Rw-8P for 29422@debbugs.gnu.org; Sun, 26 Nov 2017 10:31:53 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIyuM-0005Rg-5U; Sun, 26 Nov 2017 10:31:50 -0500 Original-Received: from [176.228.60.248] (port=4922 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eIyuL-0002Fy-Hy; Sun, 26 Nov 2017 10:31:50 -0500 In-reply-to: (message from Stefan Monnier on Sat, 25 Nov 2017 21:07:22 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140412 Archived-At: > From: Stefan Monnier > Cc: michael_heerdegen@web.de, 29422@debbugs.gnu.org > Date: Sat, 25 Nov 2017 21:07:22 -0500 > > >> > Yes, but signaling "Setting constant" when we actually mean a > >> > read-only symbol is sub-optimal, IMO. > >> That's the error that we've been using for (setq > >> enable-multibyte-characters ...) since Emacs-21. > > > ??? The code you changed signaled a "Symbol %s may not be > > buffer-local" error, not "Setting constant". What am I missing? > > My patch did not touch `setq`. It just made `make-local-variable` and > `make-buffer-local-variable` signal the same error as `setq`. Which IMO is confusing because the doc string of enable-multibyte-characters says Automatically becomes permanently buffer-local when set. > > we should at least change the ELisp manual, as it now contradicts > > the code. > > If you mean the doc of `setq`, then I guess this discrepancy has been > with us since Emacs-21. Actually, Emacs 21 said something more reasonable: Variable enable-multibyte-characters is read-only which was different from the error signaled when trying to change the value of, say, t. Only Emacs 22.1 tossed the difference and started to signal the same error for both.