From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object. Date: Fri, 08 Dec 2017 12:41:23 +0200 Message-ID: <83po7pwlgs.fsf@gnu.org> References: <87y3nga0lv.fsf@killashandra.ballybran.fr> <87h8ts1cfp.fsf@users.sourceforge.net> <87zi7kyzcf.fsf@ericabrahamsen.net> <87efov1zzn.fsf@users.sourceforge.net> <87h8trzc6e.fsf@ericabrahamsen.net> <87bmjz0xez.fsf@users.sourceforge.net> <87zi7cpooo.fsf@killashandra.ballybran.fr> <87h8tkzgef.fsf@users.sourceforge.net> <87zi76f5hj.fsf@killashandra.ballybran.fr> <87shcycavk.fsf@ericabrahamsen.net> <87lgimpdhp.fsf@ericabrahamsen.net> <87h8t8is1u.fsf@ericabrahamsen.net> <87zi6zmzh7.fsf@killashandra.ballybran.fr> <87h8t69d7b.fsf@ericabrahamsen.net> <87609lcbip.fsf@ericabrahamsen.net> <87bmjcc2rh.fsf@ericabrahamsen.net> <874lp4aije.fsf@ericabrahamsen.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1512729793 26647 195.159.176.226 (8 Dec 2017 10:43:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Dec 2017 10:43:13 +0000 (UTC) Cc: jwiegley@gmail.com, 29220@debbugs.gnu.org, pierre.techoueyres@free.fr, monnier@iro.umontreal.ca, npostavs@users.sourceforge.net To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 08 11:43:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNG7X-0006jc-Aa for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Dec 2017 11:43:07 +0100 Original-Received: from localhost ([::1]:36470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNG7e-0001Jw-JT for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Dec 2017 05:43:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNG7W-0001JY-T4 for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 05:43:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNG7S-0001Ej-9A for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 05:43:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNG7S-0001ET-4c for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 05:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eNG7R-0001L8-Uj for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 05:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Dec 2017 10:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29220 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29220-submit@debbugs.gnu.org id=B29220.15127297395099 (code B ref 29220); Fri, 08 Dec 2017 10:43:01 +0000 Original-Received: (at 29220) by debbugs.gnu.org; 8 Dec 2017 10:42:19 +0000 Original-Received: from localhost ([127.0.0.1]:51403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNG6l-0001KB-At for submit@debbugs.gnu.org; Fri, 08 Dec 2017 05:42:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNG6j-0001Jw-KW for 29220@debbugs.gnu.org; Fri, 08 Dec 2017 05:42:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNG6Z-0000W5-Q6 for 29220@debbugs.gnu.org; Fri, 08 Dec 2017 05:42:12 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNG6D-0000G4-8o; Fri, 08 Dec 2017 05:41:45 -0500 Original-Received: from [176.228.60.248] (port=2756 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eNG6C-0006iN-OR; Fri, 08 Dec 2017 05:41:45 -0500 In-reply-to: <874lp4aije.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Tue, 05 Dec 2017 14:58:45 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140809 Archived-At: > From: Eric Abrahamsen > Cc: pierre.techoueyres@free.fr (Pierre Téchoueyres), > 29220@debbugs.gnu.org, Noam Postavsky , > John Wiegley , Eli Zaretskii > Date: Tue, 05 Dec 2017 14:58:45 -0800 > > > I think so, but we're pretty late in the pretest, so better ask Eli&John > > if they think it's OK for emacs-26. > > Okay: John and Eli, this patch is to handle changes in object > implementation in Emacs 26: they are now implemented with records, which > can't be round-tripped with prin1 and read, they have to be written and > read specially. The eieio-persistent mechanism handles that, but > previously did not look inside hash tables or vectors to see if there > were objects in there. > > That's causing failure in the pcache library, which other libraries > depend on. I'm hoping we can sneak this in under the wire so that pcache > doesn't fail in Emacs 26. Fine with me to put this on emacs-26.