From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31006: [PATCH] Handle quotation marks and apostrophes in =?UTF-8?Q?=E2=80=98sgml-quote=E2=80=99?= Date: Sun, 01 Apr 2018 11:59:35 +0300 Message-ID: <83po3j7154.fsf@gnu.org> References: <20180331170035.27048-1-mina86@mina86.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1522573107 31207 195.159.176.226 (1 Apr 2018 08:58:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Apr 2018 08:58:27 +0000 (UTC) Cc: 31006@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 01 10:58:22 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2Yog-00082d-13 for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Apr 2018 10:58:22 +0200 Original-Received: from localhost ([::1]:36803 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2Yqj-00039m-CS for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Apr 2018 05:00:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2YqN-00030H-63 for bug-gnu-emacs@gnu.org; Sun, 01 Apr 2018 05:00:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2YqJ-0001Bs-8s for bug-gnu-emacs@gnu.org; Sun, 01 Apr 2018 05:00:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2YqJ-0001Bi-4g for bug-gnu-emacs@gnu.org; Sun, 01 Apr 2018 05:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f2YqI-00053n-PK for bug-gnu-emacs@gnu.org; Sun, 01 Apr 2018 05:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Apr 2018 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31006-submit@debbugs.gnu.org id=B31006.152257318619403 (code B ref 31006); Sun, 01 Apr 2018 09:00:02 +0000 Original-Received: (at 31006) by debbugs.gnu.org; 1 Apr 2018 08:59:46 +0000 Original-Received: from localhost ([127.0.0.1]:33466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2Yq2-00052s-G9 for submit@debbugs.gnu.org; Sun, 01 Apr 2018 04:59:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2Yq0-00052g-Fp for 31006@debbugs.gnu.org; Sun, 01 Apr 2018 04:59:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2Ypr-0000zI-Eq for 31006@debbugs.gnu.org; Sun, 01 Apr 2018 04:59:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2Ypr-0000z2-Aj; Sun, 01 Apr 2018 04:59:35 -0400 Original-Received: from [176.228.60.248] (port=4693 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f2Ypp-00069L-Tw; Sun, 01 Apr 2018 04:59:34 -0400 In-reply-to: <20180331170035.27048-1-mina86@mina86.com> (message from Michal Nazarewicz on Sat, 31 Mar 2018 18:00:35 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144775 Archived-At: > From: Michal Nazarewicz > Date: Sat, 31 Mar 2018 18:00:35 +0100 > > To be able to use text in an HTML argument, quotation marks need > to be replaced with an appropriate character reference. Make > ‘sgml-quote’ do that. > > While at it, fix entiteis not being unquoted if they lack closing > semicolon (e.g. ‘&’) occuring at the very end of a region. > Even though unlikely, make ‘sgml-quote’ handle this scenario. > > * lisp/textmodes/sgml-mode.el (sgml-quote): Handle quotation marks and > apostrophes. Match entities lacking semicolon at the end of regions. > * test/lisp/textmodes/sgml-mode-tests.el (sgml-quote-works): New test > case for ‘sgml-quote’ function. Thanks, this LGTM, with a minor nit: the NEWS entry should be marked "---", as sgml-quote is not currently documented in the Emacs manual. Please wait for a few days to let others comment, and if nothing else comes up, please push to the master branch with the above nit fixed.