From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32034: 26.1; [PACTH] better xref-location-marker for imperfect file locations Date: Mon, 02 Jul 2018 18:37:38 +0300 Message-ID: <83po05k5rx.fsf@gnu.org> References: <87y3etsqb7.fsf@gmail.com> <83601xlmno.fsf@gnu.org> <87muv9sll6.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1530546385 14764 195.159.176.226 (2 Jul 2018 15:46:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 2 Jul 2018 15:46:25 +0000 (UTC) Cc: 32034@debbugs.gnu.org, dgutov@yandex.ru To: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 02 17:46:20 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa11r-0003an-9o for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Jul 2018 17:46:15 +0200 Original-Received: from localhost ([::1]:33730 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa13y-0000wj-8Y for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Jul 2018 11:48:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa0uv-0001OC-JD for bug-gnu-emacs@gnu.org; Mon, 02 Jul 2018 11:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa0us-0004N1-EP for bug-gnu-emacs@gnu.org; Mon, 02 Jul 2018 11:39:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fa0us-0004Mx-AE for bug-gnu-emacs@gnu.org; Mon, 02 Jul 2018 11:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fa0us-0006f4-3s for bug-gnu-emacs@gnu.org; Mon, 02 Jul 2018 11:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jul 2018 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32034 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32034-submit@debbugs.gnu.org id=B32034.153054588525520 (code B ref 32034); Mon, 02 Jul 2018 15:39:02 +0000 Original-Received: (at 32034) by debbugs.gnu.org; 2 Jul 2018 15:38:05 +0000 Original-Received: from localhost ([127.0.0.1]:43771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa0tx-0006dY-7e for submit@debbugs.gnu.org; Mon, 02 Jul 2018 11:38:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa0tv-0006d4-CE for 32034@debbugs.gnu.org; Mon, 02 Jul 2018 11:38:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa0tp-0003TA-Ci for 32034@debbugs.gnu.org; Mon, 02 Jul 2018 11:37:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa0ti-0003P6-Iy; Mon, 02 Jul 2018 11:37:50 -0400 Original-Received: from [176.228.60.248] (port=2121 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fa0ti-0001qo-19; Mon, 02 Jul 2018 11:37:50 -0400 In-reply-to: <87muv9sll6.fsf@gmail.com> (joaotavora@gmail.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148104 Archived-At: > From: joaotavora@gmail.com (João Távora) > Cc: 32034@debbugs.gnu.org, dgutov@yandex.ru > Date: Mon, 02 Jul 2018 16:28:53 +0100 > > Eli Zaretskii writes: > > >> (beginning-of-line line) > >> - (forward-char column) > >> + (ignore-errors (forward-char column)) > >> + (unless (and (= (1+ (current-line)) line) > >> + (= (current-column) column)) > >> + (message "Intended xref location was line=%d, column=%d" > >> + line column)) > >> (point-marker)))))) > > > > What will the last hunk do when a file changed, but the identifier was > > still found? > > The function is completely oblivious to the identifier being found or > not. So it would do what it does now: jump to the wrong location And display the message, right? If so, the message would be an annoyance if displayed unconditionally, because at least the etags back-end can cope with these calamities, and users rely on that (it lets one re-generate TAGS only once in a blue moon). Or maybe I misunderstand the context in which this code runs, in which case ignore me. > > AFAIR, the etags back-end is capable of doing that > > (because it searches the file in the vicinity of the line/column if > > not found at the exact location), and it's a valuable feature, for > > obvious reasons. > > IIUC, that's what I'm proposing in my point 3: add a "hint" field to > xref-file-location and default that hint to the identifier being looked > for. If etags has code for that already, then great, we could try to > share it I don't think you can share that code, because it relies on the contents of the TAGS file, where the 'etags' utility records not only the position of the identifier, but also a string to search for it.