From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32352: 27.0.50; build error Date: Tue, 13 Nov 2018 05:35:50 +0200 Message-ID: <83pnv98x9l.fsf@gnu.org> References: <83600sueox.fsf@gnu.org> <87d0uzzkqb.fsf@gmail.com> <3ein126rxn.fsf@fencepost.gnu.org> <87lg5xhi62.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1542080107 13101 195.159.176.226 (13 Nov 2018 03:35:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2018 03:35:07 +0000 (UTC) Cc: yamaoka@jpl.org, 32352@debbugs.gnu.org, markusffm@fn.de To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 13 04:35:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMPTi-0003Hr-Lq for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Nov 2018 04:35:02 +0100 Original-Received: from localhost ([::1]:51791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMPVp-0000K7-6f for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Nov 2018 22:37:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMPVe-0000Ix-NH for bug-gnu-emacs@gnu.org; Mon, 12 Nov 2018 22:37:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMPVd-0006AW-Uu for bug-gnu-emacs@gnu.org; Mon, 12 Nov 2018 22:37:02 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gMPVd-0006AL-OE for bug-gnu-emacs@gnu.org; Mon, 12 Nov 2018 22:37:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gMPVd-00032p-K5 for bug-gnu-emacs@gnu.org; Mon, 12 Nov 2018 22:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Nov 2018 03:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32352 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32352-submit@debbugs.gnu.org id=B32352.154208021911695 (code B ref 32352); Tue, 13 Nov 2018 03:37:01 +0000 Original-Received: (at 32352) by debbugs.gnu.org; 13 Nov 2018 03:36:59 +0000 Original-Received: from localhost ([127.0.0.1]:48507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMPVb-00032Z-1W for submit@debbugs.gnu.org; Mon, 12 Nov 2018 22:36:59 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMPVZ-00032K-AW for 32352@debbugs.gnu.org; Mon, 12 Nov 2018 22:36:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMPVN-0005zi-Re for 32352@debbugs.gnu.org; Mon, 12 Nov 2018 22:36:51 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMPUa-0005je-5r; Mon, 12 Nov 2018 22:35:56 -0500 Original-Received: from [176.228.60.248] (port=1546 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gMPUZ-0000Zf-RB; Mon, 12 Nov 2018 22:35:56 -0500 In-reply-to: <87lg5xhi62.fsf@gmail.com> (message from Noam Postavsky on Mon, 12 Nov 2018 20:37:09 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152335 Archived-At: > From: Noam Postavsky > Cc: markusffm@fn.de, Eli Zaretskii , 32352@debbugs.gnu.org, Katsumi Yamaoka > Date: Mon, 12 Nov 2018 20:37:09 -0500 > > Not entirely sure about bytecomp.el vs elc, but the problem seems to be > that files.el binds read-circle over too much code, and gv.elc has some > circular structure in it. The following patch fixes it: > > --- c/lisp/files.el > +++ i/lisp/files.el > @@ -4099,7 +4099,6 @@ dir-locals-read-from-dir > Return the new class name, which is a symbol named DIR." > (let* ((class-name (intern dir)) > (files (dir-locals--all-files dir)) > - (read-circle nil) > ;; If there was a problem, use the values we could get but > ;; don't let the cache prevent future reads. > (latest 0) (success 0) > @@ -4114,7 +4113,8 @@ dir-locals-read-from-dir > (insert-file-contents file) > (let ((newvars > (condition-case-unless-debug nil > - (read (current-buffer)) > + (let ((read-circle nil)) > + (read (current-buffer))) > (end-of-file nil)))) > (setq variables > ;; Try and avoid loading `map' since that also loads cl-lib Thanks. > I guess this could go to emacs-26 I see no need to do this on the release branch, especially since a pretest of Emacs 26.2 is about to be produced. > (although I'm suddenly unable to build it today, I get tons of > "undefined reference to X" link errors (including X=main!?)). Builds fine for me, FWIW.