From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35058: [PATCH] Use display-graphic-p in more cases Date: Wed, 03 Apr 2019 08:29:01 +0300 Message-ID: <83pnq3ejxe.fsf@gnu.org> References: <8736n4ndav.fsf@gmail.com> <83tvfjgilm.fsf@gnu.org> <875zry9x94.fsf@gmail.com> <83a7hagv11.fsf@gnu.org> <87d0m4pcca.fsf@gmail.com> <83ef6kfhjf.fsf@gnu.org> <878swsp9wh.fsf@gmail.com> <838swsfdzb.fsf@gnu.org> <87r2ajbrhd.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="68983"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35058@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 03 07:29:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBYSV-000Hq5-V4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 07:29:12 +0200 Original-Received: from localhost ([127.0.0.1]:53199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBYSU-0007St-N4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 01:29:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBYSN-0007Qo-Di for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 01:29:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBYSM-000246-A3 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 01:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBYSM-00023Z-3D for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 01:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBYSL-0007SP-NT for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 01:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Apr 2019 05:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35058 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35058-submit@debbugs.gnu.org id=B35058.155426933828655 (code B ref 35058); Wed, 03 Apr 2019 05:29:01 +0000 Original-Received: (at 35058) by debbugs.gnu.org; 3 Apr 2019 05:28:58 +0000 Original-Received: from localhost ([127.0.0.1]:42041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBYSG-0007S4-A4 for submit@debbugs.gnu.org; Wed, 03 Apr 2019 01:28:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBYSD-0007Rr-C8 for 35058@debbugs.gnu.org; Wed, 03 Apr 2019 01:28:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBYS8-0001r1-5R; Wed, 03 Apr 2019 01:28:48 -0400 Original-Received: from [176.228.60.248] (port=3489 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hBYS7-0007pG-2M; Wed, 03 Apr 2019 01:28:47 -0400 In-reply-to: <87r2ajbrhd.fsf@gmail.com> (message from Alex on Tue, 02 Apr 2019 23:14:06 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157116 Archived-At: > From: Alex > Cc: 35058@debbugs.gnu.org > Date: Tue, 02 Apr 2019 23:14:06 -0600 > > >> > If it is very inconvenient to use hyper on text terminals, then I > >> > think we shouldn't require users to do that. > >> > >> It wouldn't be a matter of requiring, but instead forcing the modifier > >> back to 'meta if both in terminal Emacs and cua-rectangle-modifier-key > >> is 'hyper. > > > > Sorry, I don't understand. Can you show how would you like to remove > > the condition? > > I don't agree with my position in my last email since I found out that > my terminal has a special workaround for 'super. > > Removing the condition would just mean always using > cua-rectangle-modifier-key in cua--init-keymaps even if in a terminal: > > (setq cua--rectangle-modifier-key cua-rectangle-modifier-key) > > This would mean that terminal users that can't use super/hyper modifiers > easily would might find it confusing, but the current behaviour is a bit > confusing as is. I think the use case behind that condition is of a user who uses both GUI and TTY frames, and have cua-rectangle-modifier-key customized to something that doesn't easily work on TTY. Perhaps the right solution would be to have 2 separate defcustom's, one each for every frame type. > Why do you only say that TTY frames _generally_ don't have function > keys as symbols? Because there are exceptions, like the MS-Windows console. > How about display-symbol-keys-p (if TTY frames can't support symbols in > key sequences)? Fine with me, thanks. Although having 2 defcustom's might eliminate the need for the test and for the predicate.