From: Eli Zaretskii <eliz@gnu.org>
To: Alex Gramiak <agrambot@gmail.com>
Cc: 35464@debbugs.gnu.org
Subject: bug#35464: [PATCH] Refactor update_window_begin and update_window_end hooks
Date: Sun, 28 Apr 2019 21:45:37 +0300 [thread overview]
Message-ID: <83pnp6t1da.fsf@gnu.org> (raw)
In-Reply-To: <87zhoanfh3.fsf@gmail.com> (message from Alex Gramiak on Sun, 28 Apr 2019 12:37:28 -0600)
> From: Alex Gramiak <agrambot@gmail.com>
> Cc: 35464@debbugs.gnu.org
> Date: Sun, 28 Apr 2019 12:37:28 -0600
>
> > Also, please don't add gui_* functions extracted from the *term.c
> > files in xdisp.c, as that file is already too large. Renaming
> > existing functions in xdisp.c is OK, as well as adding static utility
> > functions. But for new gui_* functions that were originally in
> > xterm.c etc., I'd prefer a new file, let's call it gui_term.c.
>
> A gui_term.c might be beneficial in the future, but I'm not sure it
> should be the place for RIF procedures like these.
Bu these functions are not RIF procedures, they are just regular
functions.
> I attached an updated patch that currently puts them in terminal.c
> (beside update_begin and update_end), but I think a better place
> would be to put them beside update_window in dispnew.c. WDYT?
It isn't worth arguing about 2 short functions, so OK. But those in
your other patch should definitely start a new file.
next prev parent reply other threads:[~2019-04-28 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 21:28 bug#35464: [PATCH] Refactor update_window_begin and update_window_end hooks Alex Gramiak
2019-04-27 21:40 ` bug#35463: " Alex Gramiak
2019-04-28 16:45 ` bug#35464: " Eli Zaretskii
2019-04-28 18:37 ` Alex Gramiak
2019-04-28 18:45 ` Eli Zaretskii [this message]
2019-05-03 5:10 ` Alex Gramiak
2019-05-04 8:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pnp6t1da.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=35464@debbugs.gnu.org \
--cc=agrambot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).