From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36447: 27.0.50; New "Unknown keyword" errors Date: Fri, 05 Jul 2019 15:33:10 +0300 Message-ID: <83pnmoacft.fsf@gnu.org> References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> <87lfxdgs1k.fsf@web.de> <83y31capj1.fsf@gnu.org> <83tvc0anwi.fsf@gnu.org> <83r274an61.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44497"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org To: Pip Cet , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 05 14:38:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjNU1-000BQs-R9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 14:38:33 +0200 Original-Received: from localhost ([::1]:52686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjNTx-0002cx-DE for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 08:38:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54307) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjNPq-0008Oz-K1 for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 08:34:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjNPi-0004Or-2y for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 08:34:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43658) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjNPd-00048n-Ua for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 08:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjNPd-0008Fh-M7 for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 08:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2019 12:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36447 X-GNU-PR-Package: emacs Original-Received: via spool by 36447-submit@debbugs.gnu.org id=B36447.156233001131685 (code B ref 36447); Fri, 05 Jul 2019 12:34:01 +0000 Original-Received: (at 36447) by debbugs.gnu.org; 5 Jul 2019 12:33:31 +0000 Original-Received: from localhost ([127.0.0.1]:52479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjNP9-0008Ez-88 for submit@debbugs.gnu.org; Fri, 05 Jul 2019 08:33:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjNP7-0008El-83 for 36447@debbugs.gnu.org; Fri, 05 Jul 2019 08:33:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjNP0-0001Wb-5m; Fri, 05 Jul 2019 08:33:22 -0400 Original-Received: from [176.228.60.248] (port=4766 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjNOx-0004YQ-E2; Fri, 05 Jul 2019 08:33:20 -0400 In-reply-to: (message from Pip Cet on Fri, 5 Jul 2019 09:09:13 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162116 Archived-At: > From: Pip Cet > Date: Fri, 5 Jul 2019 09:09:13 +0000 > Cc: michael_heerdegen@web.de, npostavs@gmail.com, 36447@debbugs.gnu.org > > > Sorry, I don't think I know what "this bug" is about, > > The bug: Thanks for the explanations. I'm CC'ing Stefan who knows much more about this than I do. > The reasons are this: when a hash table is purecopied, its ->next > vector is purecopied, which merges it with another, similar, hash > table's ->next vector if purify-flag is a (third) hash table. The > vectors are compared using `equal', but the pure copies are actually > `eq'. A naïve question: wouldn't the problem go away if we modified purecopy not to do the above, i.e. not to merge the next vector of a hash table with that of another? > The (disappointingly trivial) fix: > call copy-sequence on h->next before rehashing the table. Rehashing is not only done during dumping, right? So the fix you propose also makes rehashing slightly less efficient. Is that necessary, i.e. are you saying that the bug is in rehashing, not in purecopy?