From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37189: Acknowledgement (25.4.1: vc-hg-ignore implementation is missing) Date: Tue, 27 Aug 2019 10:45:36 +0300 Message-ID: <83pnkrdpb3.fsf@gnu.org> References: <1ba53ae2-42a4-3ab3-d4f2-2ceae565d198@gmx.de> <52917e6f-2f00-25cf-4353-dfb40287d0ea@gmx.de> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="246967"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37189@debbugs.gnu.org To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 27 09:46:32 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2WBU-00127j-4g for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2019 09:46:32 +0200 Original-Received: from localhost ([::1]:47686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2WBS-0008G7-Ke for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Aug 2019 03:46:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59078) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2WB4-0008Fa-Va for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 03:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2WB2-0007xb-VE for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 03:46:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2WB2-0007xU-Qt for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 03:46:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2WB0-0004v3-9e for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2019 03:46:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2019 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37189 X-GNU-PR-Package: emacs Original-Received: via spool by 37189-submit@debbugs.gnu.org id=B37189.156689194118873 (code B ref 37189); Tue, 27 Aug 2019 07:46:02 +0000 Original-Received: (at 37189) by debbugs.gnu.org; 27 Aug 2019 07:45:41 +0000 Original-Received: from localhost ([127.0.0.1]:47601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2WAe-0004uL-Nq for submit@debbugs.gnu.org; Tue, 27 Aug 2019 03:45:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2WAd-0004u6-Lx for 37189@debbugs.gnu.org; Tue, 27 Aug 2019 03:45:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i2WAY-0007e0-Ai; Tue, 27 Aug 2019 03:45:34 -0400 Original-Received: from [176.228.60.248] (port=4686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i2WAX-00020v-N8; Tue, 27 Aug 2019 03:45:34 -0400 In-reply-to: <52917e6f-2f00-25cf-4353-dfb40287d0ea@gmx.de> (message from Wolfgang Scherer on Tue, 27 Aug 2019 01:25:59 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165942 Archived-At: > From: Wolfgang Scherer > Date: Tue, 27 Aug 2019 01:25:59 +0200 > > +(defun vc-hg-ignore (file &optional directory remove) > + "Ignore FILE of DIRECTORY (default is `default-directory'). > + > +FILE is a file wildcard, relative to the root directory of DIRECTORY. I think instead of "root directory of DIRECTORY" this should say "the top-level directory of DIRECTORY's repository". > +If FILE matches the regular expression > +`vc-hg-ignore-detect-wildcard', it is appended to .hgignore as > +is. Otherwise, FILE is escaped/expanded according to the active > +syntax in .hgignore. If the syntax is `regexp', FILE is quoted as > +anchored literal Python regexp and if FILE is a directory, the > +trailing `$' is omitted. Otherwise, if the syntax is `glob', > +FILE is used unquoted and if FILE is a directory, a `*' is > +appended. Our convention is to leave 2 spaces between sentences in comments and doc strings. > +When called from Lisp code, if DIRECTORY is non-nil, the "When called from Lisp" implies that this function can be called in some other way, which is generally correct only with commands. But this function is not a command, so I'm unsure what this means here. Thanks.