From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37637: 27.0.50; Segmentation fault when setting font face for new frames Date: Tue, 08 Oct 2019 12:02:56 +0300 Message-ID: <83pnj7y5hb.fsf@gnu.org> References: <878spxyjms.fsf@posteo.de> <83pnj92189.fsf@gnu.org> <877e5gxocp.fsf@posteo.de> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202164"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37637@debbugs.gnu.org To: Andreas Hilboll Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 08 11:06:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHlRp-000qF5-2L for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 11:06:25 +0200 Original-Received: from localhost ([::1]:52656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHlRi-00074Q-5O for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 05:06:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32853) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHlPb-0005cg-A0 for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 05:04:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHlPW-0000vb-CY for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 05:04:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40698) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHlPW-0000vP-9D for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 05:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHlPW-00028L-1j for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 05:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2019 09:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37637 X-GNU-PR-Package: emacs Original-Received: via spool by 37637-submit@debbugs.gnu.org id=B37637.15705254008153 (code B ref 37637); Tue, 08 Oct 2019 09:04:01 +0000 Original-Received: (at 37637) by debbugs.gnu.org; 8 Oct 2019 09:03:20 +0000 Original-Received: from localhost ([127.0.0.1]:49519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHlOq-00027R-Fn for submit@debbugs.gnu.org; Tue, 08 Oct 2019 05:03:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHlOp-00027E-3g for 37637@debbugs.gnu.org; Tue, 08 Oct 2019 05:03:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iHlOi-0008AO-9d; Tue, 08 Oct 2019 05:03:12 -0400 Original-Received: from [176.228.60.248] (port=3777 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iHlOX-0007v8-8M; Tue, 08 Oct 2019 05:03:09 -0400 In-reply-to: <877e5gxocp.fsf@posteo.de> (message from Andreas Hilboll on Mon, 07 Oct 2019 23:00:38 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168618 Archived-At: > From: Andreas Hilboll > Date: Mon, 07 Oct 2019 23:00:38 +0200 > > > Please run Emacs under a debugger and show the C-level and > > Lisp-level > > backtraces from the crash. > > Sure thing, here we go: > > (gdb) bt > #0 0x00005555557c133d in terminate_due_to_signal (sig=6, > backtrace_limit=2147483647) at emacs.c:371 > #1 0x00005555558de4c1 in die (msg=0x555555b781f0 "UNSIGNED_CMP > (DEFAULT_FACE_ID, <, FRAME_FACE_CACHE (f)->used)", > file=0x555555b7679d "font.c", line=3317) at alloc.c:7245 > #2 0x000055555596f31d in font_open_for_lface (f=0x555556a28e50, > entity=XIL(0x5555592ec375), attrs=0x5555578f9618, > spec=XIL(0x555559345925)) at font.c:3317 Thanks, please see if the patch below gives good results. diff --git a/src/font.c b/src/font.c index 935dd64..044c437 100644 --- a/src/font.c +++ b/src/font.c @@ -3314,6 +3314,9 @@ font_open_for_lface (struct frame *f, Lisp_Object entity, Lisp_Object *attrs, Li pt = XFIXNUM (attrs[LFACE_HEIGHT_INDEX]); else { + /* We need the default face to be valid below. */ + if (FRAME_FACE_CACHE (f)->used == 0) + recompute_basic_faces (f); struct face *def = FACE_FROM_ID (f, DEFAULT_FACE_ID); Lisp_Object height = def->lface[LFACE_HEIGHT_INDEX]; eassert (FIXNUMP (height));