From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38035: 27.0.50; Trivial errors in process filters can render Emacs unusable Date: Sat, 02 Nov 2019 20:36:03 +0200 Message-ID: <83pniai0rw.fsf@gnu.org> References: <874kzmdv0q.fsf@gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="39627"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38035@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 02 19:37:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQyGu-000A93-Jw for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Nov 2019 19:37:12 +0100 Original-Received: from localhost ([::1]:49882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQyGt-0002Bl-CS for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Nov 2019 14:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55172) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQyGm-0002B2-2H for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2019 14:37:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQyGl-0006vz-3F for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2019 14:37:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52505) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQyGl-0006vv-0A for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2019 14:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQyGk-0003cz-Qv for bug-gnu-emacs@gnu.org; Sat, 02 Nov 2019 14:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Nov 2019 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38035 X-GNU-PR-Package: emacs Original-Received: via spool by 38035-submit@debbugs.gnu.org id=B38035.157271978013862 (code B ref 38035); Sat, 02 Nov 2019 18:37:02 +0000 Original-Received: (at 38035) by debbugs.gnu.org; 2 Nov 2019 18:36:20 +0000 Original-Received: from localhost ([127.0.0.1]:33088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQyG4-0003bW-2f for submit@debbugs.gnu.org; Sat, 02 Nov 2019 14:36:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQyG0-0003bD-IW for 38035@debbugs.gnu.org; Sat, 02 Nov 2019 14:36:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iQyFv-0005q4-Cw; Sat, 02 Nov 2019 14:36:11 -0400 Original-Received: from [176.228.60.248] (port=2810 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iQyFt-0005vx-Ae; Sat, 02 Nov 2019 14:36:11 -0400 In-reply-to: <874kzmdv0q.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 02 Nov 2019 18:53:57 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170837 Archived-At: > From: Lars Ingebrigtsen > Date: Sat, 02 Nov 2019 18:53:57 +0100 > > (let ((process (start-process > "foo" (get-buffer-create "*foo*") > "bash" "-c" "while true; do echo foo; sleep 1; done"))) > (set-process-filter > process > (lambda (&rest _) > (error)))) > > The reason for this is that when signalling an error from a process > filter, Emacs messages the error message and then seems to sleep for a > second? Yes, see read_process_output_error_handler (it's actually 2-sec sleep), and read_and_dispose_of_process_output, where we set up for calling the process filter. > I'm not sure what solution would be best. I see two obvious things we > could do: Remove the process filter, so that it doesn't trigger again. > Or -- remove the one-second sleep, which would allow the user to `M-x > list-processes' and kill the offending process. I'd suggest to count the number of times a process filter errors out, and disable it after some configurable number. Doing that on the first error sounds too drastic: it could be a one-time spurious error.