From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Mon, 25 Nov 2019 18:00:33 +0200 Message-ID: <83pnhgrlni.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="20179"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 25 17:03:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZGpv-0004zi-VX for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 17:03:40 +0100 Original-Received: from localhost ([::1]:45956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZGpu-0006PE-4S for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 11:03:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36931) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZGnQ-0003zn-Op for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 11:01:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZGnP-0007AF-L9 for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 11:01:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43614) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZGnO-00079y-9M for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 11:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZGnO-0002KA-6w for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 11:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2019 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15746976408894 (code B ref 37774); Mon, 25 Nov 2019 16:01:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 25 Nov 2019 16:00:40 +0000 Original-Received: from localhost ([127.0.0.1]:49587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZGn2-0002JN-5r for submit@debbugs.gnu.org; Mon, 25 Nov 2019 11:00:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZGn0-0002JA-Ab for 37774@debbugs.gnu.org; Mon, 25 Nov 2019 11:00:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZGmu-0006uQ-Lz; Mon, 25 Nov 2019 11:00:32 -0500 Original-Received: from [176.228.60.248] (port=1340 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZGmt-0006UK-GX; Mon, 25 Nov 2019 11:00:32 -0500 In-reply-to: <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> (message from Dmitry Gutov on Mon, 25 Nov 2019 02:29:26 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172369 Archived-At: > From: Dmitry Gutov > Date: Mon, 25 Nov 2019 02:29:26 +0200 > > > At least, I see that even though diff-refine-added and diff-refine-removed > > faces have no :extend face attribute, but still extend to the window edge. > > Indeed. I'm attaching a screenshot to illustrate. Thanks. Face merging didn't work correctly with faces some of which have :extend non-nil and some don't, when face inheritance was involved. Should be fixed now. > BTW, the diff-context needs ':extend t' as well. Feel free to make that change (although when did you last see a context diff?). > But that's of little importance since as soon as I load a custom > theme, whatever defaults were there don't seem to matter. We need to modify all the themes we provide to specify :extend for faces where we do that by default. It seems there's no way around that, since the semantics of custom-theme-set-faces is clearly to reset all face attributes to 'unspecified' before applying the face spec, so keeping some attributes from the default face spec is out of the question, unfortunately. It's clear that the faces stuff was not designed to accommodate addition of attributes easily.