From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 28 Nov 2019 17:16:24 +0200 Message-ID: <83pnhcowtz.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <87d0dd88jr.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="243589"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, dgutov@yandex.ru To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 28 17:20:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iaMWp-0011FB-LD for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Nov 2019 17:20:27 +0100 Original-Received: from localhost ([::1]:50624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaMWo-0001qm-5D for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Nov 2019 11:20:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45515) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaLec-0004Yy-Nm for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 10:24:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaLXU-00040O-3t for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 10:17:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iaLXT-0003zf-OG for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 10:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iaLXR-0003w2-KB for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 10:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Nov 2019 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157495418915083 (code B ref 37774); Thu, 28 Nov 2019 15:17:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 28 Nov 2019 15:16:29 +0000 Original-Received: from localhost ([127.0.0.1]:59004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaLWu-0003vC-VN for submit@debbugs.gnu.org; Thu, 28 Nov 2019 10:16:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaLWt-0003uy-IL for 37774@debbugs.gnu.org; Thu, 28 Nov 2019 10:16:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iaLWi-0001Ix-CJ; Thu, 28 Nov 2019 10:16:16 -0500 Original-Received: from [176.228.60.248] (port=3594 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iaLWe-0007TE-Lv; Thu, 28 Nov 2019 10:16:13 -0500 In-reply-to: <87d0dd88jr.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 27 Nov 2019 23:30:04 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172607 Archived-At: > From: Juri Linkov > Cc: Eli Zaretskii , 37774@debbugs.gnu.org > Date: Wed, 27 Nov 2019 23:30:04 +0200 > > >>> BTW, the diff-context needs ':extend t' as well. > >> Feel free to make that change (although when did you last see a > >> context diff?). > > > > It's not for context diffs, it's for context around the changes in unified > > diffs as well. Notice the gray background on the screenshot. > > diff-context by default is just '((t nil)) > Where do you think to add ':extend t'? > To empty face definition? I don't think I understand the question. Are you asking how to do that technically? Or are you asking whether it makes sense? > >> We need to modify all the themes we provide to specify :extend for > >> faces where we do that by default. It seems there's no way around > >> that, since the semantics of custom-theme-set-faces is clearly to > >> reset all face attributes to 'unspecified' before applying the face > >> spec, so keeping some attributes from the default face spec is out of > >> the question, unfortunately. It's clear that the faces stuff was not > >> designed to accommodate addition of attributes easily. > > This means manually adding :extend to all files in etc/themes? Yes.