From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38563: 27.0.50; Company popup renders with newlines (?) inheriting the bg properties of the character at next line's bol Date: Fri, 13 Dec 2019 17:32:46 +0200 Message-ID: <83pngs6y1t.fsf@gnu.org> References: <4c2a9d55-57d1-4c19-fe20-4ccf61d20d68@yandex.ru> <83o8weaiem.fsf@gnu.org> <4220b126-0511-d6ee-521d-d79f463ab6ee@yandex.ru> <8336dpaiee.fsf@gnu.org> <2203b03e-5558-1fe1-788a-4006602626f2@yandex.ru> <83h8248wio.fsf@gnu.org> <83wob071sd.fsf@gnu.org> <0e27fa9b-67ac-c4b4-176f-f98c151d9b19@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202983"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38563@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 13 16:33:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifmwK-000qdG-UA for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 16:33:13 +0100 Original-Received: from localhost ([::1]:50478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifmwJ-0001oN-Hy for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 10:33:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55692) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifmwC-0001jr-Kq for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 10:33:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifmwB-0006wJ-HN for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 10:33:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56807) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifmwB-0006uW-DH for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 10:33:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ifmwA-0001wy-AB for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 10:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2019 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38563 X-GNU-PR-Package: emacs Original-Received: via spool by 38563-submit@debbugs.gnu.org id=B38563.15762511797487 (code B ref 38563); Fri, 13 Dec 2019 15:33:02 +0000 Original-Received: (at 38563) by debbugs.gnu.org; 13 Dec 2019 15:32:59 +0000 Original-Received: from localhost ([127.0.0.1]:34547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifmw6-0001wh-W3 for submit@debbugs.gnu.org; Fri, 13 Dec 2019 10:32:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifmw3-0001wS-N0 for 38563@debbugs.gnu.org; Fri, 13 Dec 2019 10:32:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ifmvy-0006cE-HW; Fri, 13 Dec 2019 10:32:50 -0500 Original-Received: from [176.228.60.248] (port=3727 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ifmvx-0004lb-UK; Fri, 13 Dec 2019 10:32:50 -0500 In-reply-to: <0e27fa9b-67ac-c4b4-176f-f98c151d9b19@yandex.ru> (message from Dmitry Gutov on Fri, 13 Dec 2019 17:04:21 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173281 Archived-At: > Cc: 38563@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 13 Dec 2019 17:04:21 +0200 > > On 13.12.2019 16:12, Eli Zaretskii wrote: > > > It wouldn't have worked, because ':extend nil' means the face which > > says this is ineligible for face merging when face extension is > > considered. IOW, ':extend nil' cannot countermand some other face > > that's being merged which says ':extend t'. > > Hmm, that's counter to my intuition how this should work (meaning, > :extend nil should be used during merging, like it's used during > inheritance), but maybe this way enables functionality that wouldn't be > possible otherwise. ':extend nil' is "used" during merging in the sense that such a face is skipped when we want a face for extending past EOL. How else could we implement that? Setting :extend to nil means that _none_ of the other attributes of the face are to be taken into account for merging. Inheritance just makes the inheriting face implicitly behave as if its :extend attribute is the same as of the parent face, when the inheriting face doesn't itself specify :extend, i.e. has it set to 'unspecified'. > > The problem is that the company's tooltip faces don't say ':extend t', > > so they are ineligible for merging when the face beyond EOL is > > considered. > > And we definitely wouldn't want the tooptil faces to say ':extend t'. Or > else it would not be rectangular. Sure. > > The only face which was eligible was the face of the > > first character of the line where you place your overlay. Even if it > > doesn't have ':extend t', we treat the base face (the first one being > > merged) specially: we always treat it as eligible (ever wondered how > > come 'default', 'tool-bar', and other "basic" faces get extended > > although they don't specify :extend?). > > Um, okay. I suppose they have to be extended because we need to draw > *something* at the place "occupied by" newline. Yes.