From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Date: Mon, 20 Jan 2020 21:30:28 +0200 Message-ID: <83pnfevsbv.fsf@gnu.org> References: <87y2y5lfnb.fsf@1e0.co.uk> <83eezxatsv.fsf@gnu.org> <87tv8slb6w.fsf@mattleach.net> <83a7aka1q5.fsf@gnu.org> <87sgocfh8c.fsf@mattleach.net> <83y2y48f8u.fsf@gnu.org> <87o8z0few1.fsf@mattleach.net> <83sgob98zk.fsf@gnu.org> <9ipnjdemzv.fsf@fencepost.gnu.org> <878sq0jqi6.fsf@mattleach.net> <87o8uyrlja.fsf@marxist.se> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="25542"; mail-complaints-to="usenet@ciao.gmane.io" Cc: matthew@mattleach.net, 37564@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 20 20:31:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itclV-0006Ta-KC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 20:31:13 +0100 Original-Received: from localhost ([::1]:43382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itclU-0000F2-BM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 14:31:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36498) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itclL-0000Cj-5b for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 14:31:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itclK-0001UB-4O for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 14:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40102) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itclK-0001U4-1S for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 14:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itclJ-0007Yd-U9 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 14:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 19:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37564-submit@debbugs.gnu.org id=B37564.157954863829017 (code B ref 37564); Mon, 20 Jan 2020 19:31:01 +0000 Original-Received: (at 37564) by debbugs.gnu.org; 20 Jan 2020 19:30:38 +0000 Original-Received: from localhost ([127.0.0.1]:46075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itckt-0007Xu-Aq for submit@debbugs.gnu.org; Mon, 20 Jan 2020 14:30:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itcko-0007Xb-54 for 37564@debbugs.gnu.org; Mon, 20 Jan 2020 14:30:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1itcki-0001Fn-Jo; Mon, 20 Jan 2020 14:30:24 -0500 Original-Received: from [176.228.60.248] (port=4398 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1itckf-00052l-0L; Mon, 20 Jan 2020 14:30:22 -0500 In-reply-to: <87o8uyrlja.fsf@marxist.se> (message from Stefan Kangas on Mon, 20 Jan 2020 20:10:49 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174947 Archived-At: > From: Stefan Kangas > Cc: Glenn Morris , Eli Zaretskii , > 37564@debbugs.gnu.org > Date: Mon, 20 Jan 2020 20:10:49 +0100 > > Matthew Leach writes: > > > Glenn Morris writes: > > > >> I think the point is that no terminal emulator / shell combination > >> actually exports LINES and COLUMNS as environment variables, except for > >> Emacs term.el. So no application can be relying on the LINES and COLUMNS > >> environment variables (since there aren't any applications specifically > >> for use inside Emacs's term). So term.el should stop setting them, since > >> it actually causes problems. > > > > Exactly that. By exporting these variables it's causing more problems > > than it solves. > > That sounds reasonable to me. Should we go ahead and install the > original patch on the master branch then, or is there more to discuss? Sorry, but I need more than just assertions to convince me. I have yet to see an application that doesn't cater to LINES and COLUMNS. Heck, Emacs itself does! It is true that these variables nowadays are mostly kept for the users, but that doesn't yet mean Emacs cannot use them to affect the programs it runs. As for "causing more problems than it solves", I don't think I saw any evidence for that: even the one use case which started this bug report was later shown to behave as expected. Or maybe I was just confused, in which case I'd appreciate a clear and concise description of how these variables are harmful for ncurses programs.