From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings Date: Fri, 14 Feb 2020 10:33:48 +0200 Message-ID: <83pnehpnyr.fsf@gnu.org> References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="93590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 37215@debbugs.gnu.org, larsi@gnus.org To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 14 09:34:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2WQN-000OEP-Ph for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 09:34:11 +0100 Original-Received: from localhost ([::1]:36048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2WQM-00023a-Rq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 03:34:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37746) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2WQF-00023O-I9 for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 03:34:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2WQE-0000Ls-Jk for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 03:34:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54837) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2WQE-0000LQ-G7 for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 03:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2WQE-00078x-EA for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 03:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Feb 2020 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37215-submit@debbugs.gnu.org id=B37215.158166923327441 (code B ref 37215); Fri, 14 Feb 2020 08:34:02 +0000 Original-Received: (at 37215) by debbugs.gnu.org; 14 Feb 2020 08:33:53 +0000 Original-Received: from localhost ([127.0.0.1]:60810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2WQ5-00078W-9s for submit@debbugs.gnu.org; Fri, 14 Feb 2020 03:33:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2WQ3-00078K-8l for 37215@debbugs.gnu.org; Fri, 14 Feb 2020 03:33:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2WPx-0008Dh-V6; Fri, 14 Feb 2020 03:33:45 -0500 Original-Received: from [176.228.60.248] (port=4789 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2WPw-0005lS-LN; Fri, 14 Feb 2020 03:33:45 -0500 In-reply-to: (message from Wolfgang Scherer on Fri, 14 Feb 2020 02:24:12 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176036 Archived-At: > Cc: larsi@gnus.org, 37215@debbugs.gnu.org > From: Wolfgang Scherer > Date: Fri, 14 Feb 2020 02:24:12 +0100 > > >> Your assumption, that `file` is always a simple basename is wrong. > > Yes, but when does it make sense to have FILE not absolute and not > > just a basename (i.e. with leading directories)? Do we have such use > > cases? > vc-dir-ignore with patch from #37240 OK, but then please document this use case and how DIRECTORY is used in this function. The various -ignore functions in vc.el and in backends assign different semantics to their DIRECTORY argument, and I think these (largely undocumented) differences are a source of some confusion and bugs in this area. > > Because if that happens, the file's name will be added to > > .cvsignore not in DIRECTORY but in one of its subdirectories. Would > > that be surprising? > Not for anybody familiar with CVS. This should be documented, IMO. The existing documentation of .cvsignore is minimal, and doesn't mention several important aspects. For example, the fact that only basenames are allowed is only hinted upon, and there's no information whatsoever AFAICT whether characters special to wildcards can be escaped. So I think we should provide this minimal information either in doc strings or at least in comments in the code. Thanks.