From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Fri, 29 May 2020 18:36:18 +0300 Message-ID: <83pnamn47h.fsf@gnu.org> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="86129"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tom@tromey.com, simon@polaris64.net, 41544@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 29 17:37:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeh4N-000MDb-13 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 May 2020 17:37:15 +0200 Original-Received: from localhost ([::1]:46324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeh4M-0000mS-2L for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 May 2020 11:37:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeh4A-0000m9-2v for bug-gnu-emacs@gnu.org; Fri, 29 May 2020 11:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jeh49-0005y5-Pc for bug-gnu-emacs@gnu.org; Fri, 29 May 2020 11:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jeh49-0006pw-NF for bug-gnu-emacs@gnu.org; Fri, 29 May 2020 11:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 May 2020 15:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.159076659326231 (code B ref 41544); Fri, 29 May 2020 15:37:01 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 29 May 2020 15:36:33 +0000 Original-Received: from localhost ([127.0.0.1]:55848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeh3h-0006p0-Cj for submit@debbugs.gnu.org; Fri, 29 May 2020 11:36:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeh3f-0006ol-BL for 41544@debbugs.gnu.org; Fri, 29 May 2020 11:36:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41261) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeh3Z-0005nw-Lr; Fri, 29 May 2020 11:36:25 -0400 Original-Received: from [176.228.60.248] (port=2302 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jeh3Y-0003po-53; Fri, 29 May 2020 11:36:24 -0400 In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 29 May 2020 17:17:41 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181192 Archived-At: > From: Mattias Engdegård > Date: Fri, 29 May 2020 17:17:41 +0200 > Cc: Tom Tromey , 41544@debbugs.gnu.org > > /* If the distance (as returned by color_distance) between two colors is > less than this, then they are considered the same, for determining > - whether a color is supported or not. The range of values is 0-65535. */ > + whether a color is supported or not. */ > > -#define TTY_SAME_COLOR_THRESHOLD 10000 > +#define TTY_SAME_COLOR_THRESHOLD 25000 Did you try what this does to tty-color-approximate and friends, especially when the terminal supports only 8 or 16 colors? If not, please do, we must ensure there are no regressions there. Thanks.