From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. Date: Fri, 17 Jul 2020 06:40:32 +0300 Message-ID: <83pn8ukdvz.fsf@gnu.org> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> <83zh7zjm8w.fsf@gnu.org> <87tuy786vn.fsf@bernoul.li> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25123"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42397@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 17 05:41:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwHFJ-0006R1-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jul 2020 05:41:13 +0200 Original-Received: from localhost ([::1]:51384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwHFI-00025z-1m for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 23:41:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwHFC-00025s-26 for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 23:41:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jwHF8-00083E-8L for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 23:41:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jwHF8-00078s-6S for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 23:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jul 2020 03:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42397-submit@debbugs.gnu.org id=B42397.159495725627435 (code B ref 42397); Fri, 17 Jul 2020 03:41:02 +0000 Original-Received: (at 42397) by debbugs.gnu.org; 17 Jul 2020 03:40:56 +0000 Original-Received: from localhost ([127.0.0.1]:56382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwHF2-00078R-5A for submit@debbugs.gnu.org; Thu, 16 Jul 2020 23:40:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwHEy-00078B-SW for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 23:40:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34371) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwHEs-0007wk-GS; Thu, 16 Jul 2020 23:40:46 -0400 Original-Received: from [176.228.60.248] (port=3773 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jwHEr-0007f5-Tv; Thu, 16 Jul 2020 23:40:46 -0400 In-Reply-To: <87tuy786vn.fsf@bernoul.li> (message from Jonas Bernoulli on Thu, 16 Jul 2020 23:52:44 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183130 Archived-At: > From: Jonas Bernoulli > Cc: 42397@debbugs.gnu.org > Date: Thu, 16 Jul 2020 23:52:44 +0200 > > >> I'll change that before pushing obviously. And since this commit is > >> already about *fixing* whitespace, I will also *adjust* the remaining > >> lines to use the preferred style. > > > > Please only change the whitespace where you do make changes, for the > > reasons mentioned above. > > Just to make sure: I was talking about potentially changing other lines > *within the same function* that I am already touching, and that is what > I am not supposed to do, right? Well, if those other lines are close to the ones you modify (i.e. the function is small enough), perhaps you can do that as well. It's a judgment call: the important thing is not to make too many changes that are outside of the main change's locus and only change the whitespace. > >> It might be time to revisit the decision to not fix indentation in > >> bulk. Since version Git 2.23 "git blame" can ignore the effect and > >> presence of certain commits. > > > > I don't think we want to assume 2.23 yet. I still use 2.10 on one of > > my machines, and fencepost.gnu.org has 2.3.5(!). > > One day, one day. Yes, definitely. > > I was talking about the responses. The response goes to the address > > in From and also to those in CC. Thus, responding to messages sent by > > you will always send you a copy, because you appear in From. > > Are you talking about the responses that other humans write? E.g when > you reply to > > From: Jonas, Cc: Jonas > > and you do a "reply all", then that results in > > To: Jonas, Cc: Jonas Yes. > Since I cannot find such a message, I assume you manually modified those > messages before sending. Right. And that is a mild annoyance, because it makes responding slower, and I need to pay attention to the address headers, something I'd rather not do. > My current understanding is that even if this is the case I don't really > have a choice. I need the messages that I send using "git send-email" > to appear in my email client. That only happens if I CC the message to > me. If that results in the replies to those messages arriving twice in > my inbox, then that is unfortunate but the lesser evil. (But please > enlighten me if I still get something wrong.) Can't you use BCC for that? (I'm not familiar with "git send-email" enough to tell if this is possible.)