From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5557: is undefined Date: Thu, 13 Aug 2020 16:06:34 +0300 Message-ID: <83pn7un19h.fsf@gnu.org> References: <87k19o32b2.fsf@gnus.org> <838sq4a1mm.fsf@gnu.org> <87sgoczbe5.fsf@gnus.org> <835zl8a0ur.fsf@gnu.org> <87o8z0zasn.fsf@gnus.org> <834l0sa0d0.fsf@gnu.org> <87v9t5suxx.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2524"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 5557@debbugs.gnu.org, larsi@gnus.org, lennart.borgman@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 13 15:07:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Cwo-0000WU-KH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 15:07:10 +0200 Original-Received: from localhost ([::1]:54828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Cwn-0000kg-7j for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 09:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6Cwg-0000kN-L5 for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 09:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6Cwg-0008GL-9m for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 09:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6Cwg-0001mp-4q for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 09:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Aug 2020 13:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5557 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 5557-submit@debbugs.gnu.org id=B5557.15973240106849 (code B ref 5557); Thu, 13 Aug 2020 13:07:02 +0000 Original-Received: (at 5557) by debbugs.gnu.org; 13 Aug 2020 13:06:50 +0000 Original-Received: from localhost ([127.0.0.1]:47396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6CwU-0001mP-78 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 09:06:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6CwS-0001mA-Qw for 5557@debbugs.gnu.org; Thu, 13 Aug 2020 09:06:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53869) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6CwM-0008FK-Rw; Thu, 13 Aug 2020 09:06:42 -0400 Original-Received: from [176.228.60.248] (port=4866 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6CwL-000688-RD; Thu, 13 Aug 2020 09:06:42 -0400 In-Reply-To: (message from Stefan Kangas on Wed, 12 Aug 2020 22:34:10 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185015 Archived-At: > From: Stefan Kangas > Date: Wed, 12 Aug 2020 22:34:10 -0700 > Cc: Lars Ingebrigtsen , Eli Zaretskii , 5557@debbugs.gnu.org, > lennart.borgman@gmail.com > > > Nowadays practically all applications scroll the window vertically > > regardless of where the mouse pointer is - even when it's on the > > horizontal scroll bar. The only exception is the title bar where some > > window managers optionally "roll" the window in or out. > > That strengthens the case for doing the same in Emacs. > > I have attached a patch which implements this functionality. > Any comments? I have some: > +(defun mouse-wheel--create-scroll-keys-get-key (binding event) > + "Given BINDING and EVENT, return symbol for key. > +Arguments are like in `mouse-wheel--create-scroll-keys'." > + (intern (concat (pcase (caar binding) > + ('alt "A-") ('control "C-") ('hyper "H-") > + ('meta "M-") ('shift "S-") ('super "s-")) > + (symbol-name event)))) I don't think I understand why we want to usurp mouse-wheel with every possible modifier. I think the request was to honor only unmodified mouse-wheel scrolls, no? Let's leave the modifiers to user bindings. > +(defun mouse-wheel--create-scroll-keys (binding event) > + "Return list of key vectors for BINDING and EVENT. > +BINDING is an element in `mouse-wheel-scroll-amount'. EVENT is > +an event used for scrolling, e.g. `mouse-wheel-down-event'." > + (let ((prefixes (list 'left-margin 'right-margin > + 'left-fringe 'right-fringe)) Martin says (and I concur) that we should also do this on horizontal scroll bars and on the mode/header-lines. Finally, this needs a NEWS entry. Thanks.