From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Date: Sun, 01 Nov 2020 17:32:45 +0200 Message-ID: <83pn4xf5ya.fsf@gnu.org> References: <83a6wip43q.fsf@gnu.org> <83sg9uhjy2.fsf@gnu.org> <835z6qgrwt.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7442"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44070@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 16:34:48 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZFNY-0001pi-Bj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 16:34:48 +0100 Original-Received: from localhost ([::1]:60884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZFNW-00015S-H5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 10:34:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZFMo-0000iD-7a for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 10:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZFMn-0008J3-UL for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 10:34:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZFMn-0008Nl-QD for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 10:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 15:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44070 X-GNU-PR-Package: emacs Original-Received: via spool by 44070-submit@debbugs.gnu.org id=B44070.160424478631902 (code B ref 44070); Sun, 01 Nov 2020 15:34:01 +0000 Original-Received: (at 44070) by debbugs.gnu.org; 1 Nov 2020 15:33:06 +0000 Original-Received: from localhost ([127.0.0.1]:38248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZFLt-0008IS-NZ for submit@debbugs.gnu.org; Sun, 01 Nov 2020 10:33:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZFLr-0008HA-Tv for 44070@debbugs.gnu.org; Sun, 01 Nov 2020 10:33:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56268) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZFLm-0008Dz-D3; Sun, 01 Nov 2020 10:32:58 -0500 Original-Received: from [176.228.60.248] (port=3449 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZFLk-0006ih-R2; Sun, 01 Nov 2020 10:32:57 -0500 In-Reply-To: (message from Stefan Monnier on Sun, 01 Nov 2020 08:29:09 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192404 Archived-At: > From: Stefan Monnier > Cc: 44070@debbugs.gnu.org > Date: Sun, 01 Nov 2020 08:29:09 -0500 > > >> >> How 'bout the patch below, then? > >> > LGTM, modulo the NEWS and ELisp manual updates. > >> OK, thanks. Done and pushed. > > Actually, I see now that your changes only test that a window is a > > mini-window, but not that it displays a minibuffer. Did I miss > > something? If not, I'd prefer to add the conditions for displaying a > > minibuffer, okay? > > How would I do that? I thought about testing equality between the window being redisplayed and minibuf_window. We could also look at the buffer displayed by the window, and see if it appears in Vminibuffer_list. Does that make sense?