From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46243: [External] : Re: bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo Date: Wed, 03 Feb 2021 17:56:45 +0200 Message-ID: <83pn1h401u.fsf@gnu.org> References: <83r1lz60so.fsf@gnu.org> <83a6sm5rlr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29676"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46243@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 03 16:57:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7KWq-0007Xk-06 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Feb 2021 16:57:16 +0100 Original-Received: from localhost ([::1]:57592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7KWp-00068R-2e for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Feb 2021 10:57:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7KWc-00065t-Fu for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 10:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7KWc-0001UC-9H for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 10:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7KWc-0004gw-7u for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 10:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Feb 2021 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46243 X-GNU-PR-Package: emacs Original-Received: via spool by 46243-submit@debbugs.gnu.org id=B46243.161236781818020 (code B ref 46243); Wed, 03 Feb 2021 15:57:02 +0000 Original-Received: (at 46243) by debbugs.gnu.org; 3 Feb 2021 15:56:58 +0000 Original-Received: from localhost ([127.0.0.1]:38656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7KWX-0004gX-IA for submit@debbugs.gnu.org; Wed, 03 Feb 2021 10:56:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7KWV-0004gD-MV for 46243@debbugs.gnu.org; Wed, 03 Feb 2021 10:56:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45351) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7KWP-0001NJ-ED; Wed, 03 Feb 2021 10:56:49 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4769 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l7KWM-0003Qv-Lk; Wed, 03 Feb 2021 10:56:47 -0500 In-Reply-To: <83a6sm5rlr.fsf@gnu.org> (message from Eli Zaretskii on Tue, 02 Feb 2021 19:04:00 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199209 Archived-At: > Date: Tue, 02 Feb 2021 19:04:00 +0200 > From: Eli Zaretskii > Cc: 46243@debbugs.gnu.org > > > The change was introduced in Emacs 24, AFAICT. > > In Emacs 24.4, to be exact. > > > Regression or improvement? > > Not clear yet, more analysis is required. Stay tuned. This is a consequence of fixing bug#15332. CC'ing Stefan, who both reported the bug and installed the fix. Stefan, the change you made to fix that bug, viz.: diff --git a/src/keyboard.c b/src/keyboard.c index 440820c..020c885 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -2596,10 +2596,8 @@ read_char (int commandflag, Lisp_Object map, if (/* There currently is something in the echo area. */ !NILP (echo_area_buffer[0]) - && (/* And it's either not from echoing. */ - !EQ (echo_area_buffer[0], echo_message_buffer) - /* Or it's an echo from a different kboard. */ - || echo_kboard != current_kboard + && (/* It's an echo from a different kboard. */ + echo_kboard != current_kboard /* Or we explicitly allow overwriting whatever there is. */ || ok_to_echo_at_next_pause == NULL)) cancel_echoing (); else echo_dash (); is what's causing this one: where we previously called cancel_echoing, because !EQ (echo_area_buffer[0], echo_message_buffer) was true, we now call echo_dash, because the remaining 2 conditions are false. The change you installed is not explained, so I cannot reason about the importance of echo_message_buffer. Do you remember why you decided to remove that 3rd condition?