From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47581: 27.1; tab-bar missed mouse clicks on MS-Windows Date: Mon, 12 Apr 2021 05:31:17 +0300 Message-ID: <83pmz02pze.fsf@gnu.org> References: <83pmzbeajw.fsf@gnu.org> <87mtudac4g.fsf@mail.linkov.net> <83h7kd41no.fsf@gnu.org> <878s5oebu6.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ioannis.kappas@gmail.com, 47581@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 12 04:32:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVmND-0002YF-Lw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 04:32:23 +0200 Original-Received: from localhost ([::1]:56650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVmNC-0004RI-MB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Apr 2021 22:32:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVmMs-0004R8-Br for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 22:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVmMs-0004xX-4q for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 22:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVmMs-0000nU-0M for bug-gnu-emacs@gnu.org; Sun, 11 Apr 2021 22:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Apr 2021 02:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47581 X-GNU-PR-Package: emacs Original-Received: via spool by 47581-submit@debbugs.gnu.org id=B47581.16181947053039 (code B ref 47581); Mon, 12 Apr 2021 02:32:01 +0000 Original-Received: (at 47581) by debbugs.gnu.org; 12 Apr 2021 02:31:45 +0000 Original-Received: from localhost ([127.0.0.1]:56130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVmMb-0000mx-Gp for submit@debbugs.gnu.org; Sun, 11 Apr 2021 22:31:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVmMZ-0000mk-Lz for 47581@debbugs.gnu.org; Sun, 11 Apr 2021 22:31:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45498) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVmMT-0004mH-QY; Sun, 11 Apr 2021 22:31:37 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2933 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lVmMP-0000uv-MB; Sun, 11 Apr 2021 22:31:36 -0400 In-Reply-To: <878s5oebu6.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Apr 2021 00:53:45 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203871 Archived-At: > From: Juri Linkov > Cc: ioannis.kappas@gmail.com, 47581@debbugs.gnu.org > Date: Mon, 12 Apr 2021 00:53:45 +0300 > > > I also removed note_tab_bar_highlight and the code which called it. I > > couldn't find any place which depended on that, and there was no > > visible effect of mouse-highlight on any part of the tab-bar buttons > > that I could see. If I missed something, please show a recipe where > > this highlight had any effect before my changes. > > Sorry, I don't understand the need to remove the highlighting code. > Before the removal, the tab-bar button images reacted to mouse pointer > movements, and highlighted the buttons under the mouse pointer > using the pressed/released state DRAW_IMAGE_SUNKEN/RAISED. I didn't see any such effect, and couldn't find the code which supports this highlighting. Please point out what I missed. > Now there is no visual feedback when the user moves the mouse pointer > over the buttons. Doesn't seem like an improvement. There was no visual feedback before my changes on my system, so I really don't understand what you are describing. Were you seeing that in a GTK build or a build without GTK? > > (It _is_ possible to have the tab-bar buttons react to mouse pointer > > movements, but for that we need support in display code, which isn't > > there. If we will ever want to add mouse sensitivity to tab-bar > > buttons, we should first add code which displays those buttons > > differently when the draw_glyphs_face value is DRAW_MOUSE_FACE or > > DRAW_IMAGE_SUNKEN/RAISED; then we'd want to resurrect > > note_tab_bar_highlight that I deleted.) > > Looks like a plan to re-add the same feature, but differently. >From my POV, the feature was never there.