From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: ioannis.kappas@gmail.com, 47581@debbugs.gnu.org
Subject: bug#47581: 27.1; tab-bar missed mouse clicks on MS-Windows
Date: Mon, 12 Apr 2021 05:31:17 +0300 [thread overview]
Message-ID: <83pmz02pze.fsf@gnu.org> (raw)
In-Reply-To: <878s5oebu6.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Apr 2021 00:53:45 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: ioannis.kappas@gmail.com, 47581@debbugs.gnu.org
> Date: Mon, 12 Apr 2021 00:53:45 +0300
>
> > I also removed note_tab_bar_highlight and the code which called it. I
> > couldn't find any place which depended on that, and there was no
> > visible effect of mouse-highlight on any part of the tab-bar buttons
> > that I could see. If I missed something, please show a recipe where
> > this highlight had any effect before my changes.
>
> Sorry, I don't understand the need to remove the highlighting code.
> Before the removal, the tab-bar button images reacted to mouse pointer
> movements, and highlighted the buttons under the mouse pointer
> using the pressed/released state DRAW_IMAGE_SUNKEN/RAISED.
I didn't see any such effect, and couldn't find the code which
supports this highlighting. Please point out what I missed.
> Now there is no visual feedback when the user moves the mouse pointer
> over the buttons. Doesn't seem like an improvement.
There was no visual feedback before my changes on my system, so I
really don't understand what you are describing. Were you seeing that
in a GTK build or a build without GTK?
> > (It _is_ possible to have the tab-bar buttons react to mouse pointer
> > movements, but for that we need support in display code, which isn't
> > there. If we will ever want to add mouse sensitivity to tab-bar
> > buttons, we should first add code which displays those buttons
> > differently when the draw_glyphs_face value is DRAW_MOUSE_FACE or
> > DRAW_IMAGE_SUNKEN/RAISED; then we'd want to resurrect
> > note_tab_bar_highlight that I deleted.)
>
> Looks like a plan to re-add the same feature, but differently.
From my POV, the feature was never there.
next prev parent reply other threads:[~2021-04-12 2:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 11:20 bug#47581: 27.1; tab-bar missed mouse clicks on MS-Windows Ioannis Kappas
2021-04-03 11:26 ` Ioannis Kappas
2021-04-03 13:56 ` Eli Zaretskii
2021-04-04 23:00 ` Juri Linkov
2021-04-11 9:21 ` Eli Zaretskii
2021-04-11 21:53 ` Juri Linkov
2021-04-12 2:31 ` Eli Zaretskii [this message]
2021-04-12 16:07 ` Juri Linkov
2021-04-13 13:44 ` Eli Zaretskii
2021-04-13 16:14 ` Juri Linkov
2021-04-13 16:33 ` Eli Zaretskii
[not found] ` <CAMRHuGDyM+5V46=CeqCQmhU1TrNSbCerJ531zvPKiQ-Z=NN_fQ@mail.gmail.com>
2021-04-04 19:49 ` bug#47581: Fwd: " Ioannis Kappas
2021-04-11 9:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmz02pze.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47581@debbugs.gnu.org \
--cc=ioannis.kappas@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).