From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 07/15] Add BVAR_OR_DEFAULT macro as a stub Date: Fri, 07 May 2021 16:12:29 +0300 Message-ID: <83pmy2bsci.fsf@gnu.org> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-8-sbaugh@catern.com> <837dkaddbc.fsf@gnu.org> <87k0oar8x5.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22445"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 15:13:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf0I8-0005hq-5R for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 15:13:16 +0200 Original-Received: from localhost ([::1]:40914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf0I6-0004QD-Ip for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 09:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf0Hu-0004Pp-4m for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60513) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf0Ht-0001ot-TC for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf0Ht-0006e5-NW for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162039316225536 (code B ref 48264); Fri, 07 May 2021 13:13:01 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 13:12:42 +0000 Original-Received: from localhost ([127.0.0.1]:43825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0Ha-0006do-3H for submit@debbugs.gnu.org; Fri, 07 May 2021 09:12:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0HY-0006de-T3 for 48264@debbugs.gnu.org; Fri, 07 May 2021 09:12:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47714) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf0HT-0001Z0-Ok; Fri, 07 May 2021 09:12:35 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2813 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1lf0HT-0007As-C3; Fri, 07 May 2021 09:12:35 -0400 In-Reply-To: <87k0oar8x5.fsf@catern.com> (message from Spencer Baugh on Fri, 07 May 2021 09:05:26 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205934 Archived-At: > From: Spencer Baugh > Cc: 48264@debbugs.gnu.org > Date: Fri, 07 May 2021 09:05:26 -0400 > > >> +#define BVAR_OR_DEFAULT(buf, field) BVAR (buf, field) > > > > What am I missing here? > > The commit message is accurate - we indeed use BVAR for buffer variables > without a default, and BVAR_OR_DEFAULT for buffer variables with a > default. > > It's just that in this commit, those two behave identically. The > immediate next commit makes them different. I thought I asked you not to make changes that are overwritten by subsequent patches in the series, as it makes review harder. It also makes the supposedly separate changes in the set not really separate, because one cannot revert one of them and still have a functional Emacs.