From: Eli Zaretskii <eliz@gnu.org>
To: Ioannis Kappas <ioannis.kappas@gmail.com>
Cc: 51773-done@debbugs.gnu.org
Subject: bug#51773: 28.0.60; Issue writing files over WebDAV on MS-Windows
Date: Thu, 11 Nov 2021 21:43:26 +0200 [thread overview]
Message-ID: <83pmr6zdep.fsf@gnu.org> (raw)
In-Reply-To: <CAMRHuGBu8XrBxhH6HXnLwoCWFEg+GA1M0VStH=drsyV+eJqSkg@mail.gmail.com> (message from Ioannis Kappas on Thu, 11 Nov 2021 19:22:16 +0000)
> From: Ioannis Kappas <ioannis.kappas@gmail.com>
> Date: Thu, 11 Nov 2021 19:22:16 +0000
>
> Thus a solution, which I have tested it to work, is to add the
> ERROR_INVALID_FUNCTION to the predicate
>
> diff --git a/src/w32.c b/src/w32.c
> index 9fe698d28d..0e066b12e7 100644
> --- a/src/w32.c
> +++ b/src/w32.c
> @@ -6614,10 +6614,11 @@ acl_get_file (const char *fname, acl_type_t type)
> || err == ERROR_INVALID_NAME)
> errno = ENOENT;
> else if (err == ERROR_NOT_SUPPORTED
> - /* ERROR_ACCESS_DENIED is what we get for a volume
> - mounted by WebDAV, which evidently doesn't
> - support ACLs. */
> - || err == ERROR_ACCESS_DENIED)
> + /* ERROR_ACCESS_DENIED or ERROR_INVALID_FUNCTION is
> + what we get for a volume mounted by WebDAV,
> + which evidently doesn't support ACLs. */
> + || err == ERROR_ACCESS_DENIED
> + || err == ERROR_INVALID_FUNCTION)
> errno = ENOTSUP;
> else
> errno = EIO;
>
> Please let me know if you require more info.
Thanks, installed on the emacs-28 branch (there was one more place
which needed the same fix, a few lines above the one you fixed).
prev parent reply other threads:[~2021-11-11 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 19:16 bug#51773: 28.0.60; Issue writing files over WebDAV on MS-Windows Ioannis Kappas
2021-11-11 19:22 ` Ioannis Kappas
2021-11-11 19:43 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmr6zdep.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51773-done@debbugs.gnu.org \
--cc=ioannis.kappas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).