From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51993: 29.0.50; [PATCH] Killing emacsclient terminal with `server-stop-automatically' doesn't prompt to save files Date: Sat, 20 Nov 2021 09:13:10 +0200 Message-ID: <83pmqvti49.fsf@gnu.org> References: <9e47c871-a2c3-d764-bec9-d87abf3efe83@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51993@debbugs.gnu.org To: Jim Porter , Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 20 08:14:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moKZp-00095K-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 08:14:21 +0100 Original-Received: from localhost ([::1]:49648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moKZo-0004vF-01 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 02:14:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moKZX-0004uz-BT for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 02:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moKZX-00041r-2I for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 02:14:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moKZW-0004Id-U7 for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 02:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Nov 2021 07:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51993-submit@debbugs.gnu.org id=B51993.163739239716438 (code B ref 51993); Sat, 20 Nov 2021 07:14:02 +0000 Original-Received: (at 51993) by debbugs.gnu.org; 20 Nov 2021 07:13:17 +0000 Original-Received: from localhost ([127.0.0.1]:41441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moKYn-0004H4-Fs for submit@debbugs.gnu.org; Sat, 20 Nov 2021 02:13:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moKYk-0004Gm-PV for 51993@debbugs.gnu.org; Sat, 20 Nov 2021 02:13:15 -0500 Original-Received: from [2001:470:142:3::e] (port=58194 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moKYf-0003vt-Fb; Sat, 20 Nov 2021 02:13:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Sy6ukUx2tMCj5TuZy/AKwcDYAa0ycxhaQuKf51dfbf4=; b=D+qTLwymbLBA 6fjOknnAJs09ggU2qsbSrFYEYidJhYTAk8AK4yW5uU1/qJsqIxO+Y1HRitKt/KFZ+6aGhynr0s4yK 3cHajzaWuv1Efj/FDu6l2c7IKEx2o18rwXhwzQIcCBEEHORgKcOLrYcK2RrrkIRP5lTeHusCFREAt P2ho4JjdIvOdznzoN5nG2NGfFHeco69CIJSBi6wVGNRoDcVoVOXfmaJa7yoOBGR2nkC3brrKyLLFO MPOrZaBvrt27dksqfsSHzUqmhVM+6ygggpuHSCsiAsP4Hd6X1CaSNn4CBBcJZ6eO5WcFwNAMRSets yvzdTk6EvRtAi6kQygy7WQ==; Original-Received: from [87.69.77.57] (port=2172 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moKYe-0004jO-5w; Sat, 20 Nov 2021 02:13:09 -0500 In-Reply-To: <9e47c871-a2c3-d764-bec9-d87abf3efe83@gmail.com> (message from Jim Porter on Fri, 19 Nov 2021 20:29:43 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220452 Archived-At: > From: Jim Porter > Date: Fri, 19 Nov 2021 20:29:43 -0800 > > When killing an emacsclient terminal via C-x C-c, it should prompt to > save the files initially passed to emacsclient. To see this in action: > > $ emacs -Q --daemon > $ emacsclient -a "" -c foo.txt > $ emacsclient -a "" -c bar.txt > > ;; In the first client frame: > foobar ;; Insert some text > C-x C-c > ;; Emacs prompts "Save file /path/to/foo.txt?..." > > Now try the above, but call `(server-stop-automatically 'delete-frame)' > first (or replace `delete-frame' with `kill-terminal'; it doesn't > matter). In this case, Emacs doesn't prompt to save the file. However, > the docstring/comments in `server-save-buffers-kill-terminal' say that > it should: "Offer to save each buffer, then kill the current client. ... > Only files from emacsclient file list." Gregory, any comments? Thanks.