From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56561: 29.0.50; Infloop in try_window Date: Sat, 16 Jul 2022 13:57:55 +0300 Message-ID: <83pmi5qq8c.fsf@gnu.org> References: <874jzjwmhn.fsf@md5i.com> <83v8rzsdd1.fsf@gnu.org> <878rovxqjo.fsf@md5i.com> <83sfn2sy19.fsf@gnu.org> <83lesusl4w.fsf@gnu.org> <87lesumqgf.fsf@yahoo.com> <83ilnysbc5.fsf@gnu.org> <83fsj2s8fg.fsf@gnu.org> <83cze6s7xt.fsf@gnu.org> <83bktqs724.fsf@gnu.org> <878rotlpck.fsf@yahoo.com> <834jzhsj1a.fsf@gnu.org> <87v8rxk3eb.fsf@yahoo.com> <83zgh9r2he.fsf@gnu.org> <87lestk18e.fsf@yahoo.com> <83y1wtqzqp.fsf@gnu.org> <87edyljvfs.fsf@yahoo.com> <83tu7hqvq1.fsf@gnu.org> <877d4djqhi.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8451"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mwd@md5i.com, 56561@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 16 12:59:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCfVt-00024V-Tc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 12:59:09 +0200 Original-Received: from localhost ([::1]:35188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCfVs-00069u-W0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 06:59:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCfVm-00069V-KK for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 06:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCfVm-0002gy-BX for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 06:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCfVm-00036g-7y for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 06:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2022 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56561 X-GNU-PR-Package: emacs Original-Received: via spool by 56561-submit@debbugs.gnu.org id=B56561.165796909011877 (code B ref 56561); Sat, 16 Jul 2022 10:59:02 +0000 Original-Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 10:58:10 +0000 Original-Received: from localhost ([127.0.0.1]:43056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCfUv-00035V-Vv for submit@debbugs.gnu.org; Sat, 16 Jul 2022 06:58:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCfUu-00035J-7q for 56561@debbugs.gnu.org; Sat, 16 Jul 2022 06:58:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCfUo-0002eI-St; Sat, 16 Jul 2022 06:58:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PCsJN2IseRREDb1v7nuv8pPqlV37keCOjOrCPyplaXk=; b=ap7AUtM5Envf k9Mc9TjJkKYfbsGXO0uxsEmKEHUuzsqB8Ap1ryV59PWbEh0+Y6q0rrSthbHarGEl4a6se3+swTxml /iou+Ga0qczZcLPObkQWkvnvZ/8S4uFq5h+wwiJva5zVhfe3zWyG17znscG2ELwEWoIrha3jL83it eQct87SHz246uYLl61vwuSOVLes6FhmZvxCUrH4Fmth1e3XcEEoxwsYFhaTcFd6bHB3z3cWVt68Qd 2U1TkUCDb/eg4r0hFXtDBVXpscclu6q8YcAevVtI2gZCOLblW8ZMU3x/0Z7edaqOGBLrSl93gt15O Zw/C/6isxfQgPIwjFQA13g==; Original-Received: from [87.69.77.57] (port=4367 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCfUo-0002p6-C2; Sat, 16 Jul 2022 06:58:02 -0400 In-Reply-To: <877d4djqhi.fsf@yahoo.com> (message from Po Lu on Sat, 16 Jul 2022 18:34:17 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237171 Archived-At: > From: Po Lu > Cc: mwd@md5i.com, 56561@debbugs.gnu.org > Date: Sat, 16 Jul 2022 18:34:17 +0800 > > Eli Zaretskii writes: > > >> The point I was making was that aborting in such a situation (when there > >> is no row where ends_at_zv_p is true) will result in false positives > >> when the tooltip is intentionally too small to display the entire text. > > > Yes, and so this situation should be detected, and we should avoid > > triggering the assertion violation in that case. > > Hmm. I might've missed where you explained that, but how would I go > about detecting that situation? > > The way I understand the code is that we set the window dimensions to > the max tooltip size, create a glyph matrix of that size, and then call > try_window. That is true. Which part of detecting the above situation sounds problematic to you? I'm asking because I'm uncertain what should I explain in this regard.