From: Eli Zaretskii <eliz@gnu.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: michael_heerdegen@web.de, defun.foo@proton.me, 56643@debbugs.gnu.org
Subject: bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation
Date: Fri, 22 Jul 2022 17:40:48 +0300 [thread overview]
Message-ID: <83pmhxjjm7.fsf@gnu.org> (raw)
In-Reply-To: <xjf35etnu2b.fsf@ma.sdf.org> (message from Andrea Corallo on Fri, 22 Jul 2022 13:41:32 +0000)
> From: Andrea Corallo <akrl@sdf.org>
> Cc: defun.foo@proton.me, michael_heerdegen@web.de, 56643@debbugs.gnu.org
> Date: Fri, 22 Jul 2022 13:41:32 +0000
>
> >> ("named-function-help-bookmark"
> >> (position . 1)
> >> (last-modified 25305 7198 806743 243000)
> >> (help-fn . describe-function-xref-func)
> >> (help-args completing-read "*scratch*")
> >> (position . 1)
> >> (handler . help-bookmark-jump))
> >
> > Thanks. If Andrea confirms that this won't have any problems with
> > native-compilation, I will install such changes on the release branch
> > (since AFAIU this issue is a regression in Emacs 28).
>
> I confirm it should just work.
Thanks, so I will make those changes on the release branch.
> Actually I think the use of a lambda there was not really optimal in
> first place as is not capturing anything and we were serializing and
> deserializing the same code over and over again for no good reason.
Right.
> BTW, I mention this for other similar cases, another fix would be to add
> (declare (speed -1)) to `describe-function'.
Thanks, good to know. I guess we should document that in the ELisp
manual.
next prev parent reply other threads:[~2022-07-22 14:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 13:45 bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation defun.foo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-19 16:49 ` Eli Zaretskii
2022-07-19 22:22 ` defun.foo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-20 9:51 ` Andrea Corallo
2022-07-20 11:21 ` Andrea Corallo
2022-07-20 11:45 ` Eli Zaretskii
2022-07-20 18:31 ` Andrea Corallo
2022-07-20 19:16 ` Eli Zaretskii
2022-07-20 22:47 ` Michael Heerdegen
2022-07-21 5:13 ` Eli Zaretskii
2022-07-21 10:01 ` defun.foo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-21 12:33 ` Eli Zaretskii
2022-07-22 13:40 ` Eli Zaretskii
2022-07-22 13:41 ` Andrea Corallo
2022-07-22 14:40 ` Eli Zaretskii [this message]
2022-07-23 9:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmhxjjm7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=56643@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=defun.foo@proton.me \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).