From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50507: New function in Emacs GnuTLS implementation Date: Tue, 27 Sep 2022 09:29:27 +0300 Message-ID: <83pmfhjpo8.fsf@gnu.org> References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13570"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org To: Nikolaos Chatzikonstantinou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 08:58:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1od4Xm-0003KD-72 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 08:58:14 +0200 Original-Received: from localhost ([::1]:58744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1od4Xk-0008Qk-Vx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 02:58:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od46V-0004Kp-CY for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 02:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1od46U-0000zA-T7 for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 02:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1od46U-0007a8-Iw for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 02:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 06:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 50507-submit@debbugs.gnu.org id=B50507.166426018229094 (code B ref 50507); Tue, 27 Sep 2022 06:30:02 +0000 Original-Received: (at 50507) by debbugs.gnu.org; 27 Sep 2022 06:29:42 +0000 Original-Received: from localhost ([127.0.0.1]:52266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od469-0007ZC-GU for submit@debbugs.gnu.org; Tue, 27 Sep 2022 02:29:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od467-0007Z0-TV for 50507@debbugs.gnu.org; Tue, 27 Sep 2022 02:29:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od462-0000vh-J6; Tue, 27 Sep 2022 02:29:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7gIQ1ZlhWkWLcfNvhvv8dSjX+h7syve42KiBUFCQUZs=; b=moZ6dM7fh+gUxb8S9Oqy k5BdegFrI0CYOZmUjSNemT38dbXCYEcIznWz6yxBXOBlKYQH8gEGACtJ9z38Rm4k8fE1B0ThUWvN0 UpmdplcBb0veJ/A/QpewQ7W+rE83KefYsOLHxpWCGsSK4LoHflQP5buSH7T1f0B9ikvNUbTc+5UHU zS1AJioxfQ18d4tojfuN90YQKxwpz7u2/TiQSuf0gTphuL/H+MBjd0QUU2i1IgM2fN/d1hACV5HEJ XBP2a+y3c6AdW2xiGIPizXTYeVnjXZHjfCOr/CGtxRfSvooBwHr/EiKBeBtm1ycPlBJoG4uPJcXEw GJSlnn7EHRWlqQ==; Original-Received: from [87.69.77.57] (port=1642 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od461-0006Fq-VC; Tue, 27 Sep 2022 02:29:34 -0400 In-Reply-To: (message from Nikolaos Chatzikonstantinou on Mon, 26 Sep 2022 17:39:09 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243695 Archived-At: > From: Nikolaos Chatzikonstantinou > Date: Mon, 26 Sep 2022 17:39:09 -0400 > Cc: Lars Ingebrigtsen , 50507@debbugs.gnu.org, Eli Zaretskii > > > In any case, if youʼre going to replace _file with _file2, you should > > describe the new constraints on the arguments. e.g. Maybe having pass > > as nil is OK, but then you need to say that, or maybe you need to fall > > back to _file if :pass is not specified. > > Okay, will do. The first version of the function exists since 0.4.0 > but the second appeared "recently" in 3.2.0 (released on June > 2013). Should I put some preprocessor #if checks? Yes, we already have those in gnutls.c. Example: # if GNUTLS_VERSION_NUMBER >= 0x030014 # define HAVE_GNUTLS_X509_SYSTEM_TRUST # endif > How would the docstring be affected? Instead of duplicating the > string (can't put #if inside its body, it's already in a macro), > perhaps I should write that the feature is "only supported with > GnuTLS 3.2.0 and above") You don't have to mention the GnuTLS version explicitly, you can say something more vague, like "supported by recent enough GnuTLS".