From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows Date: Thu, 13 Oct 2022 18:44:59 +0300 Message-ID: <83pmevaft0.fsf@gnu.org> References: <82k055fsos.fsf@gmail.com> <87y1tlcn7u.fsf@gnus.org> <83czaxchgp.fsf@gnu.org> <87mta1b2p9.fsf@gnus.org> <83sfjtazln.fsf@gnu.org> <87edvdays6.fsf@gnus.org> <83leplavfs.fsf@gnu.org> <871qrdavc6.fsf@gnus.org> <83ilkpauuz.fsf@gnu.org> <87r0zc88fn.fsf@gnus.org> <83wn949fui.fsf@gnu.org> <8735bs7yg0.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pquessev@gmail.com, eggert@cs.ucla.edu, 58464@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 17:46:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oj0Pd-0008QI-3u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 17:46:21 +0200 Original-Received: from localhost ([::1]:50744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oj0Pb-0004Ug-Ue for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 11:46:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj0PL-0004Jr-FX for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 11:46:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oj0PK-0006ZW-5k for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 11:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oj0PK-0005Ha-1F for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 11:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 15:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 58464-submit@debbugs.gnu.org id=B58464.166567592820261 (code B ref 58464); Thu, 13 Oct 2022 15:46:02 +0000 Original-Received: (at 58464) by debbugs.gnu.org; 13 Oct 2022 15:45:28 +0000 Original-Received: from localhost ([127.0.0.1]:34628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj0Ol-0005Gj-Nn for submit@debbugs.gnu.org; Thu, 13 Oct 2022 11:45:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj0Oj-0005GW-Rm for 58464@debbugs.gnu.org; Thu, 13 Oct 2022 11:45:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj0OY-0006Os-Ih; Thu, 13 Oct 2022 11:45:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8FLNvD8PEFs++MGpFc9SJrspOriMpA3cq7iUHlWKjy4=; b=Aq5a/gOqaxtz oPJdqzCDrr/K+Xy3VlUqgET8APp91kdEw3IwtGXCFUIsBzhYH8bQhykBcVKdyYIq33Gf1yluYSuET BhDwPzjZEKK6a3KnoXxOorKY1bbgMg/kh8J8uCG1jn9n1OJjkWqxXefYSut31I5arEhXufE1Udj9v RV1oNnUsjlZ6UMXPYT6qwdYmH0FxX9+GALkuGFjefR5i1tokApzWYKduYyYHgwQRJpK69BAHzm70z uyL653FIW3+ymp/o+fhvh+zLIt/lCm6IfQKrbh2EtVvTBydovILqBUr4BK98oINqLn2iWw9KeTQp4 05OudeCiFqp0+NK5BC92tA==; Original-Received: from [87.69.77.57] (port=2154 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj0OR-0000u0-1M; Thu, 13 Oct 2022 11:45:14 -0400 In-Reply-To: <8735bs7yg0.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 13 Oct 2022 13:30:39 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245319 Archived-At: > From: Lars Ingebrigtsen > Cc: pquessev@gmail.com, 58464@debbugs.gnu.org, Paul Eggert > > Date: Thu, 13 Oct 2022 13:30:39 +0200 > > Eli Zaretskii writes: > > > Thanks. But this part: > > > > - if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0) > > + if (save_errno != 0) > > > > might cause us signal an error when VISIT is nil, something that > > didn't happen before. > > > > (I also am not sure it is 100% reliable to rely on save_errno being > > non-zero whenever we encounter an error, especially in the > > file-handlers case.) > > That's Paul's change -- added to the CCs. Oops, sorry about that.