From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60102: Move gv-expander of substring to cl-lib Date: Fri, 16 Dec 2022 08:56:39 +0200 Message-ID: <83pmcjkfa0.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60102@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 16 07:57:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p64el-00091h-HT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Dec 2022 07:57:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p64eX-0000h9-36; Fri, 16 Dec 2022 01:57:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p64eV-0000gl-BB for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 01:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p64eU-0004wK-RK for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 01:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p64eU-0004so-FR for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2022 01:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 06:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60102 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60102-submit@debbugs.gnu.org id=B60102.167117380618759 (code B ref 60102); Fri, 16 Dec 2022 06:57:02 +0000 Original-Received: (at 60102) by debbugs.gnu.org; 16 Dec 2022 06:56:46 +0000 Original-Received: from localhost ([127.0.0.1]:47524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p64eD-0004sV-Up for submit@debbugs.gnu.org; Fri, 16 Dec 2022 01:56:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p64eB-0004sN-JM for 60102@debbugs.gnu.org; Fri, 16 Dec 2022 01:56:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p64e5-0004tp-Tn; Fri, 16 Dec 2022 01:56:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ctE3NfkzHbQHbYr1BMKGiVYSnMuRqYOf+viWrnZg4IU=; b=j1CbAdbQZ7fW /Me4S44djEQVoi2wU3P/RgKX+QwkCqHRVqgYgki2U5zY9/RYrNw48Mq54pIz67p2XcOm3qxxsHpJb gB0uJpWYVBuwDReDlLbhpDx5R1bvqntzRFFc+mHmze8HGNc5yk9WMv7sfUScwgBEdg2fOgOAGQCe0 v+F4Z6H1CJH7uQFACLZoCbxxGPIDwa31ylJ/zON9sapaMAebFgu1dzYDkmI+P1+Iy5wnn2SiS1JrB P2gCo1Wvgb/zt/jhkzorlKvhgIgGnceVe/u/cufxV2mn/TaSE72D3iYFyu2a8KlWQz/enmNSUWNHj 26tX/ZEiH8eR0vnJNHSPcQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p64e4-0003Oo-W4; Fri, 16 Dec 2022 01:56:37 -0500 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251185 Archived-At: > Date: Thu, 15 Dec 2022 15:12:06 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > The `gv-expander` of `substring` uses the `cl--set-substring` function > that's defined only in `cl-lib`, so currently, you can compile > > (setf (substring ...) ...) > > without requiring `cl-lib` but at run time it will tend to signal > a `void-function` error. > We could autoload `cl--set-substring`, but I think a better choice is to > move this `gv-expander` to `cl-lib.el`. > > There are 2 other place definitions in `gv.el` which similarly rely on > helper functions defined in `cl-lib` (namely `buffer-substring` and > `frame-visible-p`) which we could move as well, but since we marked > those as obsolete anyway I think we can "let them die" where they are, > with their quirks left alone. If you feel otherwise, I can update the > patch to move them to `cl-lib.el` as well. Is the patch for master or for the release branch? I think it should go to master. Thanks.