From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 60096@debbugs.gnu.org, juri@linkov.net
Subject: bug#60096: 29.0.60; Crash in format_mode_line_unwind_data
Date: Sat, 17 Dec 2022 17:59:36 +0200 [thread overview]
Message-ID: <83pmciggwn.fsf@gnu.org> (raw)
In-Reply-To: <a44363c8-3af7-932b-3517-6babfba68cec@gmx.at> (message from martin rudalics on Sat, 17 Dec 2022 16:26:36 +0100)
> Date: Sat, 17 Dec 2022 16:26:36 +0100
> Cc: juri@linkov.net, 60096@debbugs.gnu.org
> From: martin rudalics <rudalics@gmx.at>
>
> Alternatively, we could exclude windows with a nil buffer in
> add_window_to_list (think of the case that within the blurb
> producing code someone wants to consult the window list).
Maybe we should try this on master. I indeed expected
add_window_to_list to filter such invalid windows and was surprised
that it didn't. Basically, I don't understand how we never had such
windows in the list before, since there's no code which actively
removes them and thus protects the list from holding such windows. I
think we just have been lucky.
> Principally, we should never run 'replace-buffer-in-windows' from within
> 'set-window-configuration'.
This can no longer be guaranteed, given that other_buffer_safely calls
into Lisp, and so do a few other primitives.
> > What about the other parts of the changeset I installed -- do they
> > look okay to you? any comments?
>
> I see
>
> - return safe_call (1, Qget_scratch_buffer_create);
> + /* This function must return a valid buffer, since it is frequently
> + our last line of defense in the face of the expected buffers
> + becoming dead under our feet. safe_call below could return nil
> + if recreating *scratch* in Lisp, which does some fancy stuff,
> + signals an error in some weird use case. */
> + buf = safe_call (1, Qget_scratch_buffer_create);
> + if (NILP (buf))
> + {
> + AUTO_STRING (scratch, "*scratch*");
> + buf = Fget_buffer_create (scratch, Qnil);
> + }
> + return buf;
>
> and
>
> + Fset_buffer_major_mode (buf);
>
> which look okay to me. Unless, again, the latter would try to deal with
> the window list or do some other nasty stuff. Then other_buffer_safely
> should not be allowed to recreate *scratch* but rather some fallback
> buffer in fundamental mode with no hooks run and any buffer lists having
> it as single element.
You are right in principle, but other_buffer_safely was doing the
above for many years before we acquired get-scratch-buffer-create and
started calling it from here. So I think we are relatively safe
(again, maybe by pure chance).
Thanks.
next prev parent reply other threads:[~2022-12-17 15:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 17:04 bug#60096: 29.0.60; Crash in format_mode_line_unwind_data Juri Linkov
2022-12-15 21:42 ` Eli Zaretskii
2022-12-16 7:31 ` Juri Linkov
2022-12-16 11:46 ` Eli Zaretskii
2022-12-16 14:39 ` Eli Zaretskii
2022-12-16 15:03 ` Eli Zaretskii
2022-12-17 9:17 ` martin rudalics
2022-12-17 10:00 ` Eli Zaretskii
2022-12-17 10:53 ` Eli Zaretskii
2022-12-17 15:26 ` martin rudalics
2022-12-17 15:59 ` Eli Zaretskii [this message]
2022-12-17 17:05 ` martin rudalics
2022-12-17 17:52 ` Eli Zaretskii
2022-12-18 9:18 ` martin rudalics
2022-12-18 11:40 ` Eli Zaretskii
2022-12-17 17:23 ` Juri Linkov
2022-12-17 17:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pmciggwn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60096@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).