From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file Date: Sun, 29 Jan 2023 17:10:21 +0200 Message-ID: <83pmax74wy.fsf@gnu.org> References: <87o7r5ji3q.fsf@neverwas.me> <874jsazqzz.fsf@neverwas.me> <83edreaehg.fsf@gnu.org> <87k016y7o9.fsf@neverwas.me> <838rhmab8f.fsf@gnu.org> <874jsaumk7.fsf@neverwas.me> <875ycqt0t8.fsf@neverwas.me> <83k015976p.fsf@gnu.org> <87lelll9ha.fsf@neverwas.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4056"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, 60730@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 16:11:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pM9L5-0000tE-CH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 16:11:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pM9Ki-0005y0-MX; Sun, 29 Jan 2023 10:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM9Kh-0005xr-4g for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 10:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pM9Kg-0002Jf-T3 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 10:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pM9Kg-0007Ro-CO for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 10:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60730 X-GNU-PR-Package: emacs Original-Received: via spool by 60730-submit@debbugs.gnu.org id=B60730.167500504028597 (code B ref 60730); Sun, 29 Jan 2023 15:11:02 +0000 Original-Received: (at 60730) by debbugs.gnu.org; 29 Jan 2023 15:10:40 +0000 Original-Received: from localhost ([127.0.0.1]:45203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM9KJ-0007RB-Ru for submit@debbugs.gnu.org; Sun, 29 Jan 2023 10:10:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM9KI-0007Qy-BV for 60730@debbugs.gnu.org; Sun, 29 Jan 2023 10:10:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM9KC-0002Cf-G8; Sun, 29 Jan 2023 10:10:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qiduauj8sBlcoMY9k54w6Z4ptw1A1ZwK62UAfaYC0E4=; b=I9378d4D52jz 75zBOE/sqb5TLJ+KjClhOhw9h5VQCY+oXQBFeJAChDogCU1hoSTCldjzttVtXbh4doWRE7UK4NSiz nMOu9C0pETt3kPlxLitCemJ/Gw7q5gAI/jpn3IMJULfypwv9inLgXObcN7ossTrLPgK00C6zJ4K6F fSEv2PlDiUEcSOA1aNTYwnJvm9ZkMO1DknlM/FfyNsdhIO5O6ezFfkb2bkvx7eqGUL7v4IbLQG88E mkjNXnRTGzYuLVerhyZ3cB2gNyrQUmswjRTg5IQULmr/OI9mOO4LnXrjgHI8882wBT6OTaqy54Zl6 jUlDsc2z4FH22u7fj3S9Gw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM9KB-0007R5-5H; Sun, 29 Jan 2023 10:10:31 -0500 In-Reply-To: <87lelll9ha.fsf@neverwas.me> (jp@neverwas.me) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254359 Archived-At: > From: "J.P." > Cc: 60730@debbugs.gnu.org, stefankangas@gmail.com > Date: Sun, 29 Jan 2023 06:08:01 -0800 > > > What we need to ensure that both > > > > :coding 'raw-text > > > > and > > > > :coding some-coding-variable > > > > do work as expected, including when coding-system-for-write's value is > > a non-nil symbol of a coding-system. > > Right, whatever the solution, it should cover those bases. Although, if > `some-coding-variable' evaluates to nil, the change I proposed would not > fall back on `coding-system-for-write'. (But perhaps it should? [1]) Setting :coding to nil is unusual and I don't expect that to happen. Its semantics is tricky and most people aren't aware of that, so they (rightfully) don't use it. > diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el > index 98a017c8a8e..2605fc22ddf 100644 > --- a/lisp/emacs-lisp/ert-x.el > +++ b/lisp/emacs-lisp/ert-x.el > @@ -475,7 +475,7 @@ ert-with-temp-file > (:directory (setq directory (pop body))) > (:text (setq text (pop body))) > (:buffer (setq buffer (pop body))) > - (:coding (setq coding (pop body))) > + (:coding (setq coding (list (pop body)))) > (_ (push keyw extra-keywords) (pop body)))) > (when extra-keywords > (error "Invalid keywords: %s" (mapconcat #'symbol-name extra-keywords " "))) > @@ -484,7 +484,7 @@ ert-with-temp-file > (suffix (or suffix ert-temp-file-suffix > (ert--with-temp-file-generate-suffix > (or (macroexp-file-name) buffer-file-name))))) > - `(let* ((coding-system-for-write ,(or coding coding-system-for-write)) > + `(let* (,@(and coding `((coding-system-for-write ,(car coding)))) > (,temp-file (,(if directory 'file-name-as-directory 'identity) > (make-temp-file ,prefix ,directory ,suffix ,text))) > (,name ,(if directory I don't think this is right. coding-system-for-write exists and should be heeded because it gives the user control on binding the encoding just for this single command via "C-x RET c" prefix. By contrast, the value that comes from :coding is determined by the Lisp program, and "C-x RET c" should override it.