From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62364: 28.2; savehist file becomes quadratic when used with kill-ring and evil-yank-rectangle Date: Sat, 25 Mar 2023 15:14:56 +0300 Message-ID: <83pm8xc9j3.fsf@gnu.org> References: <83355v6e6c.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23106"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, app-emacs-dev@janestreet.com, azeng@janestreet.com, 62364-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 13:16:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg2og-0005gf-6E for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 13:16:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg2oa-0005aV-B5; Sat, 25 Mar 2023 08:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2oW-0005Re-MV for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:16:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg2oV-0002Y6-1R for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg2oU-0004c9-Qr for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:16:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62364 X-GNU-PR-Package: emacs Mail-Followup-To: 62364@debbugs.gnu.org, eliz@gnu.org, azeng@janestreet.com Original-Received: via spool by 62364-done@debbugs.gnu.org id=D62364.167974651017643 (code D ref 62364); Sat, 25 Mar 2023 12:16:02 +0000 Original-Received: (at 62364-done) by debbugs.gnu.org; 25 Mar 2023 12:15:10 +0000 Original-Received: from localhost ([127.0.0.1]:41962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2nd-0004aV-Rq for submit@debbugs.gnu.org; Sat, 25 Mar 2023 08:15:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2nb-0004aE-NG for 62364-done@debbugs.gnu.org; Sat, 25 Mar 2023 08:15:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2nV-0002Fj-R2; Sat, 25 Mar 2023 08:15:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=P63uQbpXIcifRe0er/RRt7K/wJ+gXq+BC2fMMRf4wTw=; b=EZR9+Z/E3IeI IKngwxyCFPxwHoRj/EhREJCo+atPqqjiYutcfx/sMJ6/0HliurvlzH77JSI8Ya6QEez7Fq7k3cCfs 6PbPATVD13BPPaY8ua+GqtlzefS6X7PmKYo0i+WYCaSY0eSt5oO90Lyg/AriNCcxIJjV28wcyQmDr R8H/0Z4K5fw6OZqMRsdIh5mT/XwhdL/Sxci/BGnU9he2cEWRQISQO+PwJpypna12stDTEAHVrWkso Syai5n/OUF7BbUZJABclKcK27r6g2VdH9VEWQyBAJssIH35ct2Ay41PpLoXNDOLEhjEV3BK3yig9p aEzKsHIlJV8rQSQNo3RX9A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2nU-0001rQ-V9; Sat, 25 Mar 2023 08:15:01 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 23 Mar 2023 09:04:43 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258548 Archived-At: > From: Stefan Monnier > Cc: Aaron Zeng , Lars Ingebrigtsen , > 62364@debbugs.gnu.org, app-emacs-dev@janestreet.com > Date: Thu, 23 Mar 2023 09:04:43 -0400 > > >> A suggested patch is below. For comparison, with the patch, > >> savehist-save takes less than a second and results in a 160kB savehist > >> file. > > Lars, Stefan, any comments? Are there any downsides to binding > > print-circle to a non-nil value here? > > The patch looks good to me, I can't see any downside. Thanks, installed on the emacs-29 branch, and closing the bug.