From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 62694@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp
Date: Fri, 07 Apr 2023 16:48:23 +0300 [thread overview]
Message-ID: <83pm8folaw.fsf@gnu.org> (raw)
In-Reply-To: <87ttxr3l1b.fsf@gmx.de> (message from Michael Albinus on Fri, 07 Apr 2023 14:59:44 +0200)
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: 62694@debbugs.gnu.org, joaotavora@gmail.com
> Date: Fri, 07 Apr 2023 14:59:44 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> > Alternatively, we could mark these tests as known to fail, right?
> >>
> >> This would be unfortune if there is a pylsp version on the machine which
> >> let the tests succeed.
> >
> > Why unfortunate? what am I missing?
>
> On my laptop, where the eglot pylsp tests pass, "mark these tests as
> known to fail" would result in something like this:
>
> --8<---------------cut here---------------start------------->8---
> (ert-deftest foo ()
> :expected-result :failed
> (should t))
>
> M-x ert RET foo RET
>
> Selector: foo
> Passed: 1 (1 unexpected)
> Failed: 0
> Skipped: 0
> Total: 1/1
>
> Started at: 2023-04-07 14:52:01+0200
> Finished.
> Finished at: 2023-04-07 14:52:01+0200
>
> P
>
> P foo
> passed unexpectedly
> --8<---------------cut here---------------end--------------->8---
>
> The test foo is marked red in the *ert* buffer.
I understand, but I don't see this as a problem, FWIW.
However, if you prefer marking them as unstable, I'm okay with that.
next prev parent reply other threads:[~2023-04-07 13:48 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 9:55 bug#62694: 30.0.50; eglot-tests fails with recent pylsp Michael Albinus
2023-04-06 10:54 ` João Távora
2023-04-06 11:22 ` Michael Albinus
2023-04-06 12:49 ` João Távora
2023-04-06 14:58 ` Michael Albinus
2023-04-06 16:59 ` João Távora
2023-04-06 17:39 ` Michael Albinus
2023-04-06 19:50 ` João Távora
2023-04-07 7:44 ` Michael Albinus
2023-04-07 10:20 ` João Távora
2023-04-07 10:29 ` Michael Albinus
2023-04-07 10:47 ` João Távora
2023-04-07 10:50 ` Michael Albinus
2023-04-07 10:57 ` João Távora
2023-04-07 11:04 ` Gregory Heytings
2023-04-07 11:10 ` João Távora
2023-04-07 11:11 ` Eli Zaretskii
2023-04-07 11:20 ` João Távora
2023-04-07 12:20 ` Michael Albinus
2023-04-07 10:43 ` Eli Zaretskii
2023-04-07 10:51 ` João Távora
2023-04-07 10:53 ` Michael Albinus
2023-04-07 10:59 ` Eli Zaretskii
2023-04-07 11:06 ` João Távora
2023-04-07 11:17 ` Eli Zaretskii
2023-04-07 11:23 ` João Távora
2023-04-07 11:37 ` João Távora
2023-04-07 11:41 ` Michael Albinus
2023-04-07 11:47 ` João Távora
2023-04-07 11:53 ` João Távora
2023-04-07 12:07 ` Eli Zaretskii
2023-04-07 12:13 ` Michael Albinus
2023-04-07 12:22 ` Eli Zaretskii
2023-04-07 12:40 ` João Távora
2023-04-07 12:58 ` Gregory Heytings
2023-04-07 13:02 ` João Távora
2023-04-07 13:57 ` Eli Zaretskii
2023-04-07 12:59 ` Michael Albinus
2023-04-07 13:48 ` Eli Zaretskii [this message]
2023-04-07 13:57 ` Michael Albinus
2023-04-07 14:00 ` Eli Zaretskii
2023-04-07 14:04 ` João Távora
2023-04-07 14:33 ` Eli Zaretskii
2023-04-07 15:06 ` Michael Albinus
2023-04-07 19:05 ` João Távora
2023-04-09 13:49 ` Michael Albinus
2023-04-07 12:04 ` Michael Albinus
2023-04-07 12:24 ` João Távora
2023-04-07 12:47 ` Michael Albinus
2023-04-07 13:01 ` João Távora
2023-04-07 13:04 ` Michael Albinus
2023-04-09 11:24 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 11:22 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 12:41 ` João Távora
2023-04-09 13:21 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-09 14:45 ` João Távora
2023-04-09 15:32 ` Michael Albinus
2023-04-09 15:48 ` João Távora
2023-04-09 16:08 ` Michael Albinus
2023-04-09 18:17 ` João Távora
2023-04-09 19:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pm8folaw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62694@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).