From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 62734@debbugs.gnu.org, leo.gaskin@le0.gs
Subject: bug#62734: Always fully rebuild autoloads in package-generate-autoloads
Date: Fri, 28 Apr 2023 18:48:38 +0300 [thread overview]
Message-ID: <83pm7oqa7d.fsf@gnu.org> (raw)
In-Reply-To: <874jp0aw7h.fsf@posteo.net> (message from Philip Kaludercic on Fri, 28 Apr 2023 15:00:02 +0000)
> From: Philip Kaludercic <philipk@posteo.net>
> Cc: 62734@debbugs.gnu.org, "'Eli Zaretskii'" <eliz@gnu.org>
> Date: Fri, 28 Apr 2023 15:00:02 +0000
>
> Leo Georg Gaskin <leo.gaskin@le0.gs> writes:
>
> > Tags: patch
> >
> > Hello!
> >
> > I've been using the new package-vc.el functionality to great effect,
> > but I have also come across a somewhat annoying bug. If I use any of
> > the provided commands to rebuild my local package while a autoloads
> > file is already present, the newly generated autoloads file is
> > consistently either incomplete or empty.
> >
> > The easiest way I've found to fix this is simply changing the
> > `package-generate-autoloads' function to always rebuild the autoloads
> > file by passing the relevant option to `loaddefs-generate'. I think
> > this change also makes sense on a larger scale, as package generation
> > taking into account older build artifacts seems unintuitive.
> >
> > The attached patch implements this change.
> >
> > I've read that for small changes like this no copyright assignment
> > is needed. If I have misunderstood, please point me to the relevant
> > documents so I can sign them. Please also let me know if I have
> > messed something up or you need any additional information.
>
> It seems to me that your fix is the easiest way to tackle the issue,
> without having to do a deep-dive into loaddefs. Eli, can this be
> applied to emacs-29? An alternative fix would be to restrict the
> changes to package-vc, but that seems like an unnecessary duplication,
> since the change doesn't affect package.
I don't understand the original problem (what does package-vc.el have
to do with rebuilding local packages? and why is a newly generated
loaddefs file incomplete or empty?), and I certainly don't think I
understand the effects of this change on the other usage scenarios.
Why would we want to unconditionally rebuild all the loaddefs files
every time package-generate-autoloads is invoked? OTOH, that function
is not really documented, so maybe I don't understand what is it
supposed to do and in which conditions.
IOW, I think we need more details about the problem and the proposed
solution.
next prev parent reply other threads:[~2023-04-28 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 21:16 bug#62734: Always fully rebuild autoloads in package-generate-autoloads Leo Georg Gaskin
2023-04-23 13:16 ` Philip Kaludercic
2023-04-23 14:36 ` Leo Gaskin
2023-04-25 12:35 ` Philip Kaludercic
2023-04-28 15:00 ` Philip Kaludercic
2023-04-28 15:48 ` Eli Zaretskii [this message]
2023-04-28 18:00 ` Philip Kaludercic
2023-04-28 18:11 ` Eli Zaretskii
2023-04-28 18:22 ` Philip Kaludercic
2023-04-29 5:43 ` Eli Zaretskii
2023-04-29 8:19 ` Philip Kaludercic
2023-04-29 10:32 ` Eli Zaretskii
2023-04-29 11:18 ` Philip Kaludercic
2023-04-29 12:21 ` Eli Zaretskii
2023-04-30 9:17 ` Philip Kaludercic
2023-04-30 10:08 ` Eli Zaretskii
2023-04-30 16:45 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pm7oqa7d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62734@debbugs.gnu.org \
--cc=leo.gaskin@le0.gs \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).