From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Date: Wed, 10 May 2023 18:53:13 +0300 Message-ID: <83pm786v4m.fsf@gnu.org> References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> <873548wuwe.fsf@ericabrahamsen.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15612"; mail-complaints-to="usenet@ciao.gmane.io" Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 10 17:53:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwm7u-0003l9-0f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 May 2023 17:53:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwm7n-0003N3-Vj; Wed, 10 May 2023 11:53:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwm7i-0003M0-4X for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 11:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwm7h-0004XK-Sz for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 11:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwm7h-00023q-P2 for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 11:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs Original-Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.16837339357861 (code B ref 62845); Wed, 10 May 2023 15:53:01 +0000 Original-Received: (at 62845) by debbugs.gnu.org; 10 May 2023 15:52:15 +0000 Original-Received: from localhost ([127.0.0.1]:48784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwm6x-00022j-EG for submit@debbugs.gnu.org; Wed, 10 May 2023 11:52:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwm6v-00022S-Fb for 62845@debbugs.gnu.org; Wed, 10 May 2023 11:52:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwm6p-0004Oq-5o; Wed, 10 May 2023 11:52:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sU7d0XLrlZBZhqWfNkXeUKD7QO+l5mPpFhnKu0NJFhc=; b=BwoMsJNPEUFU 2iXliD5388zKKHFJVn0VoC0FSYD9fLTuq+WRAdMovTBNMA4dVfrmfZCV0TnrbPT3RlS+Lsln0qgs+ c2cogF2k0AtTihRJzTZC9BonaiwlhB1s2nO38O1qrYlZwVb+mc55YMKO03qPogVHcRUmUolQf7nqG q5R/bIk8gTl8YTGKHG0XZXwjbsndzI8vfCeaPTz0cN/x0aTRLn4qulkkFqbFWNSgFX61S6MYj5Aue //S8ggWbUPqtbzXpUAPPF08R8NUSOghbpojmXX1IHEmF9gZ7QM+ElRJ/T28ztmFfnRSvAsT61HqMo b102aq0hiHThfZHysYSMSA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwm6o-0005mO-MU; Wed, 10 May 2023 11:52:06 -0400 In-Reply-To: <873548wuwe.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Sat, 06 May 2023 22:52:17 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261514 Archived-At: > From: Eric Abrahamsen > Cc: Eli Zaretskii , 62845@debbugs.gnu.org > Date: Sat, 06 May 2023 22:52:17 -0700 > > > On 05/06/23 19:43 PM, Andreas Schwab wrote: > > On Mai 06 2023, Eric Abrahamsen wrote: > > > > You cannot recreate a buffer once it is killed. You can create a new > > buffer, but it will always be a different buffer. > > But `nntp-possibly-change-group' re-initializes `nntp-server-buffer' to > a new buffer, and the `nntp-find-connection-buffer' inside > `nntp-retrieve-group-data-early' uses the value of `nntp-server-buffer' > to find its process. My reading is that each time the with-open-group > function runs, its `bodyfun' lambda should get a new opportunity to find > a live `nntp-server-buffer'. > > Plus, if the buffer were already dead the second time through, > `nntp-retrieve-group-data-early' has sufficient guards to simply bail > before doing anything. > > I'm not trying to be stubborn here, I assume your analysis is > essentially right, I'm just trying to make sure I actually understand > what's happening in the code. > > Even if it does require two timeouts in a row, I get that plenty often > with a `nntp-connection-timeout' value of 6. Eric, any progress here? If no better ideas are ready to be implemented, I think we should revert that commit on emacs-29 and leave it on master, where work on fixing this fallout should continue. OK?