From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64071: 28.2; smerge-diff creates *vc-diff* without setting it up Date: Wed, 28 Jun 2023 14:41:33 +0300 Message-ID: <83pm5fvmoi.fsf@gnu.org> References: <83ttv9tcnh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16588"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64071@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 28 13:42:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qETYw-00045w-Cw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Jun 2023 13:42:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qETYp-0006rb-SA; Wed, 28 Jun 2023 07:42:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qETYg-0006Yo-42 for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 07:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qETYf-0001FC-PI for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 07:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qETYf-0004Bw-L6 for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 07:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2023 11:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64071 X-GNU-PR-Package: emacs Original-Received: via spool by 64071-submit@debbugs.gnu.org id=B64071.168795247716054 (code B ref 64071); Wed, 28 Jun 2023 11:42:01 +0000 Original-Received: (at 64071) by debbugs.gnu.org; 28 Jun 2023 11:41:17 +0000 Original-Received: from localhost ([127.0.0.1]:50139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qETXx-0004Aq-34 for submit@debbugs.gnu.org; Wed, 28 Jun 2023 07:41:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qETXu-0004Ab-KO for 64071@debbugs.gnu.org; Wed, 28 Jun 2023 07:41:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qETXo-0000JH-On; Wed, 28 Jun 2023 07:41:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bQ+ZQjlk2pnBdzj0NnUNZEZ2rO3kgZ/UKK2QO6UYw3I=; b=m0pt+b/Cz8M2 ySFMiefWuIoJynhuNKmFurbGEFqzQKJ2keEsP3hiLYJvbJyvK2o2SsmEft7Z497g0emiU9TzOkwZE lNHfcMww1mpNOZ26kBaf33bmtHqh4uqWBC2jlN5iDI2M1xa0OUzD4083MHp4aCXmCcfxO08z7VDvj dBCHR2M0lk6n0UcJSNAHyWJ2xB9Y3XQW5y3g1bIHKjaeSLLp1kqhArq/wLjvdDJGJzCBI/d33f8p8 A5GSdkQbF3pOuxgENGW+b3XRK/b2zfEL+4v6vJ6h6l+i3aii3jFDjSKnDpgCuwJU3bw6JJoBPZB33 NGGpsxSW1J3d3Ke0SKxOVg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qETXo-00031M-7m; Wed, 28 Jun 2023 07:41:08 -0400 In-Reply-To: (message from Spencer Baugh on Tue, 27 Jun 2023 16:17:45 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264203 Archived-At: > From: Spencer Baugh > Cc: Stefan Monnier , 64071@debbugs.gnu.org > Date: Tue, 27 Jun 2023 16:17:45 -0400 > > Eli Zaretskii writes: > > > That command enters diff-mode, and diff-mode doesn't force read-only > > status on the current buffer. Why should Smerge force that? > > Buffer named "*vc-diff*" are universally read-only, except if they are > created through this path. But users can legitimately make a *vc-diff* buffer modifiable, no? And your patch silently makes it read-only again, behind the user's back. That's hardly nice, is it? > Stefan likes my simple patch, so what's wrong with it? See above: we shouldn't change the read-only attribute that was set by the user.