From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62732: 29.0.60; uniquify-trailing-separator-p affects any buffer whose name matches a dir in CWD Date: Thu, 13 Jul 2023 19:02:01 +0300 Message-ID: <83pm4v4x6u.fsf@gnu.org> References: <87h6tpn8d5.fsf@catern.com> <87edotn7sx.fsf@catern.com> <87edlhm6wq.fsf@catern.com> <87o7kklf9c.fsf@catern.com> <83r0pf9b7d.fsf@gnu.org> <83fs5v8tsw.fsf@gnu.org> <83edlf89qp.fsf@gnu.org> <83v8eq7j3i.fsf@gnu.org> <83pm4y79dw.fsf@gnu.org> <83y1jl5jrq.fsf@gnu.org> <83o7kg5s9o.fsf@gnu.org> <87mszzkduy.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26437"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, monnier@iro.umontreal.ca, 62732@debbugs.gnu.org To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 18:02:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJymD-0006d7-Vd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 18:02:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJyld-0000tf-MD; Thu, 13 Jul 2023 12:02:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJylW-0000pZ-N5 for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 12:02:02 -0400 Original-Received: from [2001:470:142:5::43] (helo=debbugs.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJylW-0005Wp-Dy for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 12:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJylW-0001ke-5L for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 12:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62732 X-GNU-PR-Package: emacs Original-Received: via spool by 62732-submit@debbugs.gnu.org id=B62732.16892641186723 (code B ref 62732); Thu, 13 Jul 2023 16:02:02 +0000 Original-Received: (at 62732) by debbugs.gnu.org; 13 Jul 2023 16:01:58 +0000 Original-Received: from localhost ([127.0.0.1]:40641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJylS-0001kN-52 for submit@debbugs.gnu.org; Thu, 13 Jul 2023 12:01:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJylO-0001k8-1C for 62732@debbugs.gnu.org; Thu, 13 Jul 2023 12:01:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJylH-0005Si-2z; Thu, 13 Jul 2023 12:01:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TfLXbheJJqhe3d7wT6vJ03O9KhWR+3V2P8AOlWZMqaY=; b=bJP/eABggj7R Yb6wldkee4XoJAJabPs+RlxqJEMm6D8u6R7NHpDwjLPtGVsnoQAyuErHxbWOc95GsE31iefZWoByY m98WYA/WMdxqkHf/U4m3XtuAv8YjBqN4tEFjwMEuKtHAxSKVvAn88YAVzgg+80XsOmPqVkyEJ/Fd2 ajjbqUK+tw4Ky42mI8iPm2xPyBnM5asCFCkHciGFoHaBZQuxu+kJOIpQBU9//85m/nkKZIAztsGsy UdMHTfCW/D9QNrcF6/Rtth42OTI1wS2U+JjdWjQLGbmUWQiWKYfG+7NAOggqZfTKvCWMz/UtVG5+l asgh2rCO1OXGlPkJwbdHIQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJylG-0004sP-J0; Thu, 13 Jul 2023 12:01:46 -0400 In-Reply-To: <87mszzkduy.fsf@catern.com> (sbaugh@catern.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265027 Archived-At: > From: sbaugh@catern.com > Date: Thu, 13 Jul 2023 15:52:54 +0000 (UTC) > Cc: monnier@iro.umontreal.ca, sbaugh@janestreet.com, 62732@debbugs.gnu.org > > Eli Zaretskii writes: > > > So how about compromising on a variant of (2): we add an optional > > DIRECTORY-P argument, and if FILENAME doesn't end in a slash, but > > DIRECTORY-P is non-nil, create-file-buffer will append a slash? > > Okay, so like this? Looks like you sent an incorrect patch or something? > BTW, would you be okay with moving uniquify-trailing-separator-p into > dired, as I described in my other recent email? Then create-file-buffer > wouldn't need to check it, which would simplify its docstring slightly; > instead dired would just decide whether to pass a directory name or file > name based on uniquify-trailing-separator-p. Since I'm changing this > area anyway, now would be the time to make that change, as a nice > cleanup which Stefan also likes. I don't quite understand how can uniquify-trailing-separator-p be in dired.el when the code which supports it is in uniquify.el. What am I missing?