From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64406: [PATCH] Improve commands to manage Python imports Date: Sat, 15 Jul 2023 11:25:59 +0300 Message-ID: <83pm4td1ig.fsf@gnu.org> References: <874jmnbd5v.fsf@gmail.com> <87pm534puk.fsf@gmail.com> <87lefr399j.fsf@gmail.com> <87bkgl39bm.fsf@gmail.com> <83cz0w5opl.fsf@gnu.org> <87jzv3v7tv.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arstoffel@gmail.com, 64406@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 10:26:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKabY-000ASH-3w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 10:26:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKabL-0000ge-2b; Sat, 15 Jul 2023 04:26:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKabK-0000gU-Bb for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 04:26:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKabK-0000vf-3D for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 04:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKabJ-0002Y5-Ur for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 04:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 08:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64406 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64406-submit@debbugs.gnu.org id=B64406.16894095469772 (code B ref 64406); Sat, 15 Jul 2023 08:26:01 +0000 Original-Received: (at 64406) by debbugs.gnu.org; 15 Jul 2023 08:25:46 +0000 Original-Received: from localhost ([127.0.0.1]:44068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKab3-0002XY-PJ for submit@debbugs.gnu.org; Sat, 15 Jul 2023 04:25:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKab1-0002XI-BB for 64406@debbugs.gnu.org; Sat, 15 Jul 2023 04:25:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKaav-0000tK-UV; Sat, 15 Jul 2023 04:25:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DDxX/6o5xzhPJ8CytvZECYUijajQc1W9Lq7vel3FLF8=; b=T+uY77Ce4LnK hGpqSqk85xqfMpXvV3yt79mYjs8Lm6nTkInPsTABAnK/p8yc7Y6NbPRBR4NmJCH2tEFGDlVQDUEyP C61nLk4FKYB1Jq5BnUxr1D7kAdhxgh9U20Nd9XbYz1wIGhf8lfk4bi7ofSxvNV3kziOuw7Q0zXxUz bdNDXJXZtP+ubcGQMMnNIDCbUcWQPOoYSpDKNfmLMh0SYK7dZIUa3/4a9rYQbAjV5FNTZAQFSnim3 x4nJ2d8odsuTsV5rIC19XLzslhUuzeUztuKN24y/eGw1TZ2DSh57CIGCxKaxuOOolz8tq+DQ7Ua5n XciyBt5x0x0n6LwlqT6lig==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKaav-0001wM-Ed; Sat, 15 Jul 2023 04:25:37 -0400 In-Reply-To: <87jzv3v7tv.fsf@gmail.com> (message from Matthias Meulien on Thu, 13 Jul 2023 23:07:40 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265168 Archived-At: > From: Matthias Meulien > Cc: arstoffel@gmail.com, 64406@debbugs.gnu.org > Date: Thu, 13 Jul 2023 23:07:40 +0200 > > > Thanks. Could you please make a single patch from these two? There's > > no need to revert the original one in a separate patch. > > Yes. > > >> Subject: [PATCH 1/2] Fix "Improve Python imports management commands" > >> > >> * lisp/progmodes/python.el (python--do-isort): The isort library don't > >> check for its version itself! > > > > I don't think I understand this log entry. What does it mean "the > > isort library don't check its version"? > > You're right, it doesn't make sense. > > > >> + ((eq 3 status) " (maybe isort version is less than 5.7.0?)") > > ^^^^^^^ > > Here, "is older" should be more clear, I think. > > Ok. Thanks, installed on master. Please in the future always mention the bug number, when known, in the commit log message (I did it this time for you).