From: Eli Zaretskii <eliz@gnu.org>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: 63627@debbugs.gnu.org
Subject: bug#63627: Improve plstore.el and fix various issues of it
Date: Sat, 02 Sep 2023 10:41:53 +0300 [thread overview]
Message-ID: <83pm319g3i.fsf@gnu.org> (raw)
In-Reply-To: <8b00a564-c0d2-3072-50bc-530c50fa25b2@vodafonemail.de> (message from Jens Schmidt on Thu, 31 Aug 2023 12:21:38 +0200)
> Date: Thu, 31 Aug 2023 12:21:38 +0200
> Cc: 63627@debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
>
> On 2023-08-31 06:46, Eli Zaretskii wrote:
> >> Date: Wed, 30 Aug 2023 21:28:10 +0200
> >> Cc: 63627@debbugs.gnu.org
> >> From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
>
> >> Next set of patches, I hope they are still eligible for emacs-29.
> >>
> >> The first patch fixes more documentation and terminology issues in
> >> plstore.el, still without touching any code. The second patch
> >> comprise ERT tests for plstore.el. Since that requires interaction
> >> with GnuPG, these tests are rather platform-dependent. Test setup
> >> should ensure that all tests are skipped if GnuPG is missing or not
> >> appropriate for the tests.
> >
> > Documentation fixes are always welcome on the release branch.
> >
> > As for tests: I don't really object, but what would be the purpose of
> > extending the test suite on the release branch? why not install that
> > on master instead?
>
> I thought about adding tests for 1-2 pending bugs in plstore.el in near
> future. But OTOH, these bugs are really not that significant, so
> probably it makes indeed more sense to add the tests to master only.
OK, so I've now installed the documentation changes on emacs-29.
Please prepare the other patch for master, and let's install it there.
> >> Please check.
> >
> > What would you like me to check?
>
> Nothing in particular. Like: "Please check whatever you must check
> before committing such changes."
>
> Actually, it *would* be interesting to know what you check in such a
> situation, if it could be easily described.
I look at the commit log message, make sure the relevant tests still
pass, and do anything else my eyes suggest while looking at the patch.
Thanks.
next prev parent reply other threads:[~2023-09-02 7:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 15:45 bug#63627: Improve plstore.el and fix various issues of it Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-22 20:11 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-31 12:54 ` Eli Zaretskii
2023-06-16 19:43 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 19:28 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-31 4:46 ` Eli Zaretskii
2023-08-31 10:21 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 7:41 ` Eli Zaretskii [this message]
2023-09-03 22:22 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07 9:12 ` Eli Zaretskii
2023-09-07 19:27 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-08 5:40 ` Eli Zaretskii
2023-09-08 9:16 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-08 11:34 ` Eli Zaretskii
2023-09-08 21:24 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 21:24 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-16 10:13 ` Eli Zaretskii
2023-09-16 10:35 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-16 11:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pm319g3i.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63627@debbugs.gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).