From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames Date: Sun, 03 Sep 2023 14:44:38 +0300 Message-ID: <83pm2z7a6x.fsf@gnu.org> References: <87sf9gozbl.fsf@ledu-giraud.fr> <83fs5g8392.fsf@gnu.org> <87lef8ovgc.fsf@ledu-giraud.fr> <835y6c7yvo.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36188"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64791@debbugs.gnu.org, manuel@ledu-giraud.fr To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 13:46:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qclYN-0009BG-KY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 13:46:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qclYF-0001zb-H7; Sun, 03 Sep 2023 07:45:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qclY7-0001z5-Mc for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:45:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qclY7-0008C7-EU for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:45:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qclYH-0004Zm-O3 for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 11:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64791 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64791-submit@debbugs.gnu.org id=B64791.169374152017531 (code B ref 64791); Sun, 03 Sep 2023 11:46:01 +0000 Original-Received: (at 64791) by debbugs.gnu.org; 3 Sep 2023 11:45:20 +0000 Original-Received: from localhost ([127.0.0.1]:39849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qclXc-0004Yh-5W for submit@debbugs.gnu.org; Sun, 03 Sep 2023 07:45:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qclXZ-0004YL-9r for 64791@debbugs.gnu.org; Sun, 03 Sep 2023 07:45:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qclXI-0007jX-8s; Sun, 03 Sep 2023 07:45:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MSoyxBQphwiQJLDW7LlTg1tV1MpIEtysY4KAP9IELp8=; b=hQY6GzBOpPQu DnePZjOKOIMre1V/OJb4olqWXEEXq+8+rrKU1F65Q7bXSzeDGQLwlPzFi1ioqPfXOMemiqJOI81YO 3BXk5R4AP7d2e9HE0EdiKMpAaqH1cz7GSylQkrVF+ZHG/vWHp6rMLqP3ZvN9HpC2K/Vnk4Zp4NWTM /jE0IT53bKLH4lPEG9hbdUj8hScJmI4d2KuN2r6jku4cDY0epp3+bUxWHWi/Gk4X/BlyM/NgauIcv /ZwqGdxRmR9ALxNL36++YsH07zeQXDJKnqUrApeqO8x2UP4av4+/67HTooF83XEX2JSg2+N9sy7ri l+bJ+TRlVdYp74JIPJKzUw==; In-Reply-To: (message from Stefan Kangas on Sun, 3 Sep 2023 04:34:38 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269151 Archived-At: > From: Stefan Kangas > Date: Sun, 3 Sep 2023 04:34:38 -0700 > Cc: Manuel Giraud , 64791@debbugs.gnu.org > > Eli Zaretskii writes: > > >> From: Manuel Giraud > >> Cc: 64791@debbugs.gnu.org > >> Date: Sat, 22 Jul 2023 16:46:27 +0200 > >> > >> Eli Zaretskii writes: > >> > >> > I'm not sure there can be the end to such fixes. The real fix is to > >> > use GNU 'ls' which has special support for Dired (or use ls-lisp.el). > >> > I guess you don't have GNU 'ls', since you are on OpenBSD? > > Yup. Perhaps we should consider checking for the existence of "gls" and > using that. E.g., I use the following, here: > > (if (and (memq system-type '(berkeley-unix darwin)) > (executable-find "gls")) > (setq insert-directory-program "gls")) > > But I've only tested this on macOS so far, so I'm not sure how well this > would work on *BSD. From memory, I think it should be fine. Perhaps > Manuel can say what he thinks. > > >> You're right I'm using OpenBSD's ls. But I thought it was a reasonable > >> fix: it seems more obvious then looking for something that looked like a > >> file size. > > > > Maybe. Let's hear what others think about this. > > FWIW, I don't think I mind such portability fixes. It wouldn't be a bad > thing if Dired played a bit more nicely on BSD machines. > > The point that this could be a slippery slope is valid, but we can also > choose to reject further tweaks on a case-by-case basis. The format of > ls is also inherently stable: many things depend on it. > > On the other hand, the fix I propose above might be all that is needed > in many cases. I'm still undecided. And it doesn't help that none of *BSD users except you spoke up.