From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66150: 30.0.50; Duplicate :tag in remote-file-name-inhibit-cache Date: Fri, 22 Sep 2023 14:37:51 +0300 Message-ID: <83pm2a781c.fsf@gnu.org> References: <87wmwimto3.fsf@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28198"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66150@debbugs.gnu.org, michael.albinus@gmx.de To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 13:39:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjeV1-0007BO-UY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 13:39:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjeUm-0006Cc-Ph; Fri, 22 Sep 2023 07:38:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjeUl-0006CT-GS for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 07:38:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjeUl-0007BR-8f for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 07:38:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjeUv-0006jH-PA for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 07:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 11:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66150-submit@debbugs.gnu.org id=B66150.169538268625804 (code B ref 66150); Fri, 22 Sep 2023 11:39:01 +0000 Original-Received: (at 66150) by debbugs.gnu.org; 22 Sep 2023 11:38:06 +0000 Original-Received: from localhost ([127.0.0.1]:35446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjeU1-0006i7-6C for submit@debbugs.gnu.org; Fri, 22 Sep 2023 07:38:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjeTt-0006hO-Vj for 66150@debbugs.gnu.org; Fri, 22 Sep 2023 07:38:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjeTd-00075A-75; Fri, 22 Sep 2023 07:37:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=AYtznCzIKPVnqEsDvOMgw6+e2TZfZHW4TL/8QoYsX9U=; b=VOWLjWk4v90Cf6b25DpZ 1eGVz+xWIaPT0cM2z3FupN+Ys3VNPeSM9JNlV19gICOA2RXaboiDB+xnAaZDVjCvMLuLiaL/ZC8cz 4rDurwbuoM22rqiO3uGctY7UAXqW0j4p1hwuqYjwEPnYtx9mkNbJ7RpqN2dMDTKHa0HEFJBR27TZP kwtISlh1S9NIpp4im8Q5W+wWb/SNbHhUOwWVt50RcWURIxdk5/1Dr3qM3fq6azmTlHVla7eL+jxbg KI+GiUQnT93BwGa0i63CjicuW4RtUjB3jUv19pNpakVkL/JDTTsjqTc3Ag9txtekp7mN3OOYF7UM0 Jpcn4MYiX5v1ow==; In-Reply-To: <87wmwimto3.fsf@epfl.ch> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271073 Archived-At: > Cc: Michael Albinus > Date: Fri, 22 Sep 2023 11:41:32 +0200 > From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Building master, I see the following warning: > > In toplevel form: > files.el:1327:12: Warning: in defcustom for ‘remote-file-name-inhibit-cache’: > duplicated :tag string in ‘choice’: "Do not use file name cache" > > Is the following patch acceptable? With changes, see below. > - (const :tag "Do not inhibit file name cache" nil) > - (const :tag "Do not use file name cache" t) > - (integer :tag "Do not use file name cache" > - :format "Do not use file name cache older then %v seconds" > + (const :tag "Inhibit remote file cache" t) > + (const :tag "Cache remote file attributes" nil) > + (integer :tag "Cache remote file attributes with expiration" > + :format "Cache expiry in seconds: %v" > :value 10))) Let's be consistent. Either (a) the t value should have the tag of "Do not cache remote file attributes", or (b) the nil and the integer values should have the tag "Do not inhibit remote file cache" and "Inhibit file cache if expired", respectively. OK? > If it's acceptable, does it belong on master or emacs-29? emacs-29, please.