From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument Date: Sat, 30 Dec 2023 09:43:07 +0200 Message-ID: <83plyo3zlg.fsf@gnu.org> References: <838r6g7ih8.fsf@gnu.org> <86sf3rqyzy.fsf_-_@mail.linkov.net> <831qbabfni.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14739"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67452-done@debbugs.gnu.org To: juri@linkov.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 30 08:44:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rJU0w-0003fY-I6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Dec 2023 08:44:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rJU0o-0002gL-R0; Sat, 30 Dec 2023 02:44:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJU0o-0002gD-70 for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 02:44:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rJU0n-0002D3-RP for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 02:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rJU0o-0003S4-5T for bug-gnu-emacs@gnu.org; Sat, 30 Dec 2023 02:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Dec 2023 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67452-done@debbugs.gnu.org id=D67452.170392220513215 (code D ref 67452); Sat, 30 Dec 2023 07:44:02 +0000 Original-Received: (at 67452-done) by debbugs.gnu.org; 30 Dec 2023 07:43:25 +0000 Original-Received: from localhost ([127.0.0.1]:42960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJU0C-0003R5-RP for submit@debbugs.gnu.org; Sat, 30 Dec 2023 02:43:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJU0B-0003Qr-3v for 67452-done@debbugs.gnu.org; Sat, 30 Dec 2023 02:43:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJU05-0001pq-CK; Sat, 30 Dec 2023 02:43:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gnAYkrnn4lbVX//Q3iOilYm7fEYxS5c2JLRwt+x3g9Q=; b=mkf9D8dfwTIB zHjOLb6IsjaGZMXnk8tJgpzig+7W4gno10Z5M7+bThHQpZqTTkb1j9F1a65gmeGE8BVhBTykezKAZ bygoUwfvu9b9gZz3npRwReYknuq0EF4z6MjD8tVOeUPLdB/0Q607GDI6ZEN6Z2rAiXUGkNjzL9Sry JhkybPhmO9xWaWE3xey+x/GwQ2v+seJ5FsufVvLAvgkDtCPFT4lxeu9qzV3Rxu/Q+FDIrFHOJGl/Z 45dA+m/TUs9OlQzQgz3iXSkYx4TSgYuJfeBlY/OCBgTb/194YsjkT5QsepNDBctzh+MJerA98X05G KH7CMJjVsYJ7gEYtfrxHUQ==; In-Reply-To: <831qbabfni.fsf@gnu.org> (message from Eli Zaretskii on Mon, 25 Dec 2023 15:00:49 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277063 Archived-At: > Cc: 67452@debbugs.gnu.org > Date: Mon, 25 Dec 2023 15:00:49 +0200 > From: Eli Zaretskii > > > From: Juri Linkov > > Date: Sun, 24 Dec 2023 19:41:37 +0200 > > > > > Thanks, I've now installed the change on the emacs-29 branch, using > > > the "p" interactive spec, and I'm closing this bug. > > > > The commit cd477bf07d8 broke normal use of split-root-window commands > > without arguments: > > > > 0. emacs-29 -Q > > 1. C-x 2 > > 2. C-x w 3 > > > > Debugger entered--Lisp error: (error "Window # too small for splitting") > > error("Window %s too small for splitting" #) > > split-window(# 1 t) > > split-window-right(1 #) > > split-root-window-right(1) > > funcall-interactively(split-root-window-right 1) > > command-execute(split-root-window-right) > > > > because the "p" interactive spec uses SIZE=1. > > Thanks, should be fixed now on the emacs-29 branch. No further comments, so I presume the bug was fixed, and I'm closing it.