From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67687: Feature request: automatic tags management Date: Sun, 31 Dec 2023 09:07:03 +0200 Message-ID: <83plym3l60.fsf@gnu.org> References: <2f86b882-9ec1-f63f-d90b-5f8f7ae114f2@gutov.dev> <58D84A29-9A63-45BA-AD8B-B476CDC931A1@gmail.com> <812729c8-726f-d60e-2603-2d8e588929fd@gutov.dev> <835y0sgg12.fsf@gnu.org> <661f4951-cb0a-5257-63b0-efe71a0d217e@gutov.dev> <83y1de7jyr.fsf@gnu.org> <1a8c51fb-a114-42a4-ae40-8314d3f21104@gutov.dev> <83tto0400p.fsf@gnu.org> <6a684420-2098-4c9f-a17c-61150e9f3321@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13480"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67687@debbugs.gnu.org, eskinjp@gmail.com, stefankangas@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 31 08:08:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rJpvx-0003KP-Si for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Dec 2023 08:08:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rJpvX-0008Uo-JH; Sun, 31 Dec 2023 02:08:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJpvW-0008UM-9J for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2023 02:08:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rJpvW-00014I-0y for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2023 02:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rJpvW-00007h-GQ for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2023 02:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Dec 2023 07:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67687 X-GNU-PR-Package: emacs Original-Received: via spool by 67687-submit@debbugs.gnu.org id=B67687.1704006441415 (code B ref 67687); Sun, 31 Dec 2023 07:08:02 +0000 Original-Received: (at 67687) by debbugs.gnu.org; 31 Dec 2023 07:07:21 +0000 Original-Received: from localhost ([127.0.0.1]:45538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJpuq-00006b-Rn for submit@debbugs.gnu.org; Sun, 31 Dec 2023 02:07:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJpuo-00006P-5s for 67687@debbugs.gnu.org; Sun, 31 Dec 2023 02:07:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJpuh-000102-7m; Sun, 31 Dec 2023 02:07:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yStS81FgoVC3G4cIDaOj3lJ6aasuKhzOb2q6QTdxW8U=; b=MDAiF3eDbBkq TMShk9cz17kjwj3KE+T1N/3gAorhgkr7UfDM5N05zFJcB6yasD9JlxLd4a2PiatQzlZt17W6WW7Yt VEpCwMlPlgJRvmLWiXV+ow2vQvpjGpipq71Ol/K2pV67k13Y3qIfz1XoqTf13zM29T+o7p/ZmVvtg mxro5pDY5bC+dTWzV78eOqc6o5ax8IBIPGO1n4S+XORcm8uUlXKwBWkaqCF0boIP3p3Nm9RLmcqPO E0KqEunz/UJ3WUwPfFJc4gx7ARJ95lM6OrbHcv3wlPtiMEgQ6ewpEuTzDFqe7kT4QZ0+sTWTS7sTC fShHu3w4SmUK5BJIC3sq2A==; In-Reply-To: <6a684420-2098-4c9f-a17c-61150e9f3321@gutov.dev> (message from Dmitry Gutov on Sun, 31 Dec 2023 01:43:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277128 Archived-At: > Date: Sun, 31 Dec 2023 01:43:25 +0200 > Cc: 67687@debbugs.gnu.org, eskinjp@gmail.com, stefankangas@gmail.com > From: Dmitry Gutov > > >>>> +;;;###autoload > >>>> +(put 'etags-regen-file-extensions 'safe-local-variable > >>>> + (lambda (value) (and (listp value) (seq-every-p #'stringp value)))) > >>> > >>> Why not use list-of-strings-p here? > >> > >> Again, that "core ELPA" consideration. We could deploy this feature to a > >> number of released Emacs versions, if we don't introduce such dependencies. > > > > Isn't this covered by the compat package on ELPA? If not, I think it > > should be. > > These forms go into generated autoloads file for each installed package > (*-autoloads.el). I think compat doesn't make list-of-string-p > autoloaded, and autoloads files don't usually have (require ...) forms. > > So while I haven't really tested this and could be missing something, it > seems brittle to rely on 'compat' for this function (if at all possible). It is also extremely ugly to have those large functions in a bundled package, when we already have list-of-strings-p in Emacs 29. So how about defining list-of-strings-p in etags-regen for older versions, and then using it in the safe-local-variable property? Or some other solution to make this more elegant. Wanting to let users use this with older Emacsen has its limits, and IMNSHO this one crosses that limit. > Latest revision attached. Any further comments? None from me, thanks.