From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals Date: Tue, 09 Jan 2024 14:40:11 +0200 Message-ID: <83plyaptn8.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68334@debbugs.gnu.org To: Jared Finder Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 13:41:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNBPs-00083A-6U for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 13:41:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNBPj-0003Om-Ke; Tue, 09 Jan 2024 07:41:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNBPd-0003O4-HD for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 07:40:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNBPb-0007ZP-P9 for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 07:40:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNBPi-0005jG-Hq for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 07:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 12:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68334 X-GNU-PR-Package: emacs Original-Received: via spool by 68334-submit@debbugs.gnu.org id=B68334.170480404821990 (code B ref 68334); Tue, 09 Jan 2024 12:41:02 +0000 Original-Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 12:40:48 +0000 Original-Received: from localhost ([127.0.0.1]:38613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNBPU-0005ic-48 for submit@debbugs.gnu.org; Tue, 09 Jan 2024 07:40:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNBPS-0005iQ-Qn for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 07:40:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNBPG-0007OX-El; Tue, 09 Jan 2024 07:40:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aeWI0Zb24aqeztvBMtOhhHhLTF4eL/b/rSbN1Y2hvLw=; b=NFDajHCiBJXT +dxnBYL/der40cfqV5Igztu0PsKwVIBliHFCeg0GO8TTh7PRKRqqXaBnkLUzbZIP4Q+ZUQ9z2QNJx e1ncngJc85rAcJpdjRcbTP1xTQNMdjuaJXnulwOHdgZKIpaLaM9oX87Xu9wh9G5wkr0G2Uksfv39g oI1cZkYemeVt6bkV7MMULENgsZ/Xk5lK87cFhYf0B9jh1hRraO+UgMYPUhYajQ9Q3x/NUTJ6Wr4iU cV0moUsn0rjkishqnDXuuc6FdX27jW0Kzwvt6fWyK0dUwamjEnW2R7RItJgTP8lofj7C5S4sVzf1I HuZiGWP4MIMBhazmqD5TjQ==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277623 Archived-At: > Date: Mon, 08 Jan 2024 13:39:25 -0800 > From: Jared Finder via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I'd like tool-bar-make-keymap-1 to return a sensible keymap on > terminals. This is only a small change from current code, patch > attached. I don't see any problems with the change, but please add comments there explaining that some parts of the code are supposed to work on frames where images cannot be displayed, because it is very easy to mistakenly assume this only needs to work on GUI frames. Btw, what happens if display-images-p returns non-nil, but the session doesn't support images of the type used for tool-bar icons?